Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/64#discussion_r101719487
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
---
@@ -461,7 +461,11 @@ public void start() throws MQClientException {
*/
@Override
public void shutdown() {
- this.defaultMQPushConsumerImpl.shutdown();
+ shutdown(0);
+ }
+
+ public void shutdown(long awaitTerminateMillis) {
--- End diff --
Since `MQPushConsumer` only has the method interface for `shutdown( )`, so
we could consider pull `shutdown(long awaitTerminateMillis)` up to the parent
interface or make `shutdown(long awaitTerminateMillis)` private and give a
default input(non-zero) in `shutdown()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
