Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/64#discussion_r101723621
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
---
@@ -461,7 +461,11 @@ public void start() throws MQClientException {
*/
@Override
public void shutdown() {
- this.defaultMQPushConsumerImpl.shutdown();
+ shutdown(0);
+ }
+
+ public void shutdown(long awaitTerminateMillis) {
--- End diff --
@zhouxinyu
I know and agree to your concern, actually, as I my previous comment, maybe
we could add an configuration for awaitMills, what do you think ? The default
value could be 0 to keep the same behavior
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
