Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130528221
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start() throws MQClientException {
}
private void startScheduledTask() {
- if (null == this.clientConfig.getNamesrvAddr()) {
--- End diff --
I think what @qqeasonchen says makes sense, but we have discuss what
behavior we want to have.
To me, if addresses have been manually specified,
it makes sense to fetch name servers only if a call to manually specified
servers fail. No need to do periodic calls. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
