Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131043380
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
    @@ -255,19 +255,17 @@ public void start() throws MQClientException {
         }
     
         private void startScheduledTask() {
    -        if (null == this.clientConfig.getNamesrvAddr()) {
    -            this.scheduledExecutorService.scheduleAtFixedRate(new 
Runnable() {
    +        this.scheduledExecutorService.scheduleAtFixedRate(new Runnable() {
    --- End diff --
    
    I don't see the problem if you agree that: dynamical fetch should only be 
trigged when user does not specify the ns explictly.
    
    So it means 
    if(USER DOES NOT SPECIFY NS) {
        startFetch
    }
    
    where USER DOES NOT SPECIFY NS equals to `null == 
this.clientConfig.getNamesrvAddr()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to