Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130850910
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
    @@ -255,19 +255,17 @@ public void start() throws MQClientException {
         }
     
         private void startScheduledTask() {
    -        if (null == this.clientConfig.getNamesrvAddr()) {
    --- End diff --
    
    @shroman 
    
    while to me, I will consider that if the nameserver address is specified 
manually, no dramatically fetch should be triggered since we should respect 
what user's choice. Or they may be confusing about the inconsistent behavor.
    
    So, I would think the existing design for:
    
    1. when specified nameserver address, no need to fetch nameserver address 
dymatically.
    2. Only fetch nameserver address when user has not specified manully.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to