Piotr, Carlos, Please read and respond. Others are welcome to give their thoughts as well.
Just to be clear, MDLBlogExample is an attempt to exactly replicate an example from Google's MDL repo. Google's example contains HTML and CSS files and the example uses text content from the HTML files and CSS from the CSS files and the content is under CC-BY-4.0 which, from what I can tell from the background information I've read, is only in Category B because of a usage restriction and not because it is "copyleft". The usage restriction concern is that the ASF does not want CC-BY lines of code mixed with regular ALv2 code since that would effectively poison the ALv2 code. You wouldn't be able to use it "everywhere". So I have asked VP Legal if, because our CC-BY content is contained in an example and we prominently label it, there is negligible risk of having other ALv2 code poisoned. Even if you were to build your own Blog app from MDLBLogExample, you are almost certain to replace the text content, and would probably alter the styles as well, although you would be warned that if you don't, CC-BY restrictions apply to your app. Unless the VP Legal agrees that the risk is "ok" because we've prominently labelled the CC-BY-4.0 content, our choices are (that I have thought of so far): 1) Bundle only the ALv2 stuff and exclude from -bin packages: This involves changing the build scripts to download the CSS file. And either replace the text content with something else or also figure out how to get the build/download scripts to extract the text content from the HTML file (sounds painful). Users opening the -bin package will not be able to run the example. They will have to build it themselves. 2) Create an "Extras" repository somewhere. This is a separate, non-Apache repo where people could put things that aren't fully ALv2 compliant. Some other ASF projects have Extras on SourceForge. I think they have warning signs that code in an Extras repo is not officially released. We could post a pre-compiled MDLBlogExample there, but we still couldn't bundle it with our regular -bin packages. There could be a script in the NPM install that asks if you want it and gets it for you. We could go back to using an Installer like the Flex Installer so we can ask everyone if they want MDLBlogExample, but we can't make it ready-to-run for everyone by default. 3) Convince Google to change the licensing on their HTML and CSS files. All of these options are non-trivial, IMO, and so several folks have suggested temporarily removing MDLBlogExample from this first release until we hear back from VP Legal or execute on one of these options. MDLExample is currently being treated like MDLBlogExample. That's because I think it is trying to replicate some of the examples from material.io and is directly using some CSS and I think some text from some HTML files in the MDL Github repo. I'm unclear whether the main screen is our design or a replication of a component explorer that Google created. Unless the goal of MDLExample is to exactly replicate something else, MDLExample has a fourth choice, IMO, where we create custom styles and text content so there is no more CC-BY content. But again, that is also non-trivial work, so if we want to get a release out soon, the fastest way is to temporarily remove this example from this first release. It can be easily brought back later depending on what we decide. Regardless of what we choose, we all have to get better at reviewing the commits when new code is involved. If you are copying something you saw somewhere else, try to make sure it gets reviewed, maybe even before committing. Thanks, -Alex On 1/17/18, 4:57 AM, "Piotr Zarzycki" <[email protected]> wrote: >We have to also exclude MDLBlogExample from ANT build, because ANT is >producing distribution package for IDE usage not Maven. > >Thanks for explanation, so by deprecation you mean rather recommendation >to >the users some other UI module instead of MDL. Not removing it completely >from the framework set. Because deprecation to me is always towards to one >thing: >1) Mark something as deprecated >2) Remove it in some future version. > >Piotr > > >2018-01-17 13:46 GMT+01:00 Carlos Rovira <[email protected]>: > >> Hi Piotr >> >> 2018-01-17 13:29 GMT+01:00 Piotr Zarzycki <[email protected]>: >> >> > Hi Carlos, >> > >> > I think removing MDLBlogExample completely will be better, cause we >>don't >> > need to remember in every release about exclusion of that example. >> > >> >> exclusion in maven is only not to list in modules section, so I think is >> not much problem right? >> >> >> > >> > What do you mean by "deprecate that library" in terms of open source >> > project ? >> > >> >> If we'll get a UI set build exclusively for Royale that has themeing >> feature and replicates MDL (and other look and feels), then we can >> deprecate it, in terms that "we'll no longer update MDL library and you >> should use the new UI Set for any new project you build". So the use >>we'll >> be for people that already use it, and if they can migrate to the new >>want >> would be better. I always said that MDL was made to boost Royale grow >>and >> make people put an eye, but with a well done UI set it should be >>useless in >> the future >> >> thanks >> >> >> > >> > Thanks, Piotr >> > >> > >> > 2018-01-17 13:24 GMT+01:00 Carlos Rovira <[email protected]>: >> > >> > > Hi, >> > > >> > > I think MDLExample is one of the most referred examples out there. I >> > > couldn't follow all the discussion since I was busy with work and >>other >> > > task in this project, but I read that we had some problems with >>images. >> > We >> > > can change the images for place holders. If there's some more >>problem I >> > > don't know right now. >> > > >> > > About MDLBlogExample is unfinished and can be not released. I found >> some >> > > blocking problems with CSS compiler when tried to complete. If can >>be >> > > removed from release but maintain the code I think it would be ok. >> > > >> > > In the end, now we rely heavily in MDL, but we should work forward a >> > future >> > > where we can deprecate that library in favor of our own UI component >> set >> > > that could have the same appearance with a theme. >> > > >> > > Thanks >> > > >> > > >> > > >> > > >> > > >> > > 2018-01-17 10:28 GMT+01:00 Piotr Zarzycki >><[email protected]>: >> > > >> > > > Olaf, >> > > > >> > > > I'm against even for that. MDLExample should be always in release >> > > package. >> > > > If I understand Alex's idea the things should be fixed in the >>commit >> > > time, >> > > > so now we have release time. We had that issue for several >>releases, >> we >> > > can >> > > > leave with it one more release. >> > > > >> > > > Thanks, Piotr >> > > > >> > > > >> > > > 2018-01-17 10:24 GMT+01:00 Olaf Krueger <[email protected]>: >> > > > >> > > > > Hi Piotr, >> > > > > just to make sure you don't get it wrong: >> > > > > >> > > > > The idea is to just remove it from the RC2 (So from the first >> Royale >> > > > > release >> > > > > at the end) just in order to have some more time to fix the >> > IP/license >> > > > > issues and so don't delay the release any longer. >> > > > > >> > > > > This does not mean that those examples aren't less important, of >> > > course!! >> > > > > >> > > > > If I understand Alex correctly, the idea is to have continuous >> > release >> > > > > cycles, e.g. every 2 or 4 weeks so that we can add the >>MDL_Example >> > soon >> > > > > again. >> > > > > If I can do anything, I'd like to offer some help in order to >>fix >> > those >> > > > > issues. >> > > > > >> > > > > Is it already clear what we have to do to fix those issues? >> > > > > If it's not so much effort we maybe could do it right now and >>keep >> it >> > > > with >> > > > > RC2? >> > > > > >> > > > > Just my thoughts, >> > > > > Olaf >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Sent from: >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-ro >>yale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui%40adobe.com >>%7C7e852751df3c4dfea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C >>0%7C0%7C636517906468287536&sdata=cWjGgMTY8KD3MsvZ4T9WDTWPy5HKZtJD6dpI0bS% >>2F0bc%3D&reserved=0 >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > >> > > > Piotr Zarzycki >> > > > >> > > > Patreon: >>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c >>4dfea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179 >>06468287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D& >>reserved=0 >> > > > >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c >>4dfea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179 >>06468287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D& >>reserved=0>* >> > > > >> > > >> > > >> > > >> > > -- >> > > Carlos Rovira >> > > >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me% >>2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c4dfea0b108 >>d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651790646828753 >>6&sdata=OT8ThGUjHpiJWzR5RyD7lk2pw3J3IoTPbadBBUW7kOk%3D&reserved=0 >> > > >> > >> > >> > >> > -- >> > >> > Piotr Zarzycki >> > >> > Patreon: >>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c >>4dfea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179 >>06468287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D& >>reserved=0 >> > >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c >>4dfea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179 >>06468287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D& >>reserved=0>* >> > >> >> >> >> -- >> Carlos Rovira >> >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me% >>2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c4dfea0b108 >>d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651790646828753 >>6&sdata=OT8ThGUjHpiJWzR5RyD7lk2pw3J3IoTPbadBBUW7kOk%3D&reserved=0 >> > > > >-- > >Piotr Zarzycki > >Patreon: >*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c4d >fea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179064 >68287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D&rese >rved=0 ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C7e852751df3c4d >fea0b108d55da9db38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365179064 >68287536&sdata=ggXVOiwZjDZtBK%2FAXREVc7CuchCO%2B0F%2FtIgrmPOex%2FM%3D&rese >rved=0>*
