Hi Alex, I don't know too much about Royale extras, I think it was an effort of Harbs. Hope he could throw some light on this hopefully tomorrow. Thanks for looking at it.
Carlos El sáb., 1 sept. 2018 a las 1:44, Alex Harui (<aha...@adobe.com.invalid>) escribió: > I found some time to look into the Maven build on builds.a.o. > > AFAICT, the reason it is working for us locally but not on builds.a.o is > because the google_maps build is trying to call Git to patch the externs > file. On builds.a.o, it is unable to find git. My theory is that some > configuration changed and Git is no longer in the path. > > While we could ask infra what the path is to Git, or figure it out > ourselves, in looking at old emails, it appears that a royale-extras repo > exists to try to eliminate the need to patch these externs. Can someone > confirm this? I tried just skipping the patch step and the build failed, > so it appears that what is in royale-extras for google_maps is > "pre-patch". This implies that one possible solution is to update > royale-extras with the post-patch extern. This would be preferable, IMO, > since it would be less config dependent and thus more likely to work on > builds.a.o and elsewhere. Can someone confirm this is the case, and better > yet, make the required changes? > > That said, if I am right and updating google_maps in royale-extras and > removing the patch step fixes the build, my next question is about how we > are handling the code in royale-extras. Is this an ASF thing, someone's > personal thing, something else? We may need to review our LICENSE/NOTICE > files? > > Thanks, > -Alex > > -- Carlos Rovira http://about.me/carlosrovira
