Hi Harbs, Can you take the patched google_maps_api_v3_11.js from a local royale-typedefs build or maybe from apacheroyaleci and commit it to royale-extras? I don't want to deal with the technicalities of whether I can commit to royale-extras from my employer's perspective.
Then you should be able to remove the patch step from the ant and maven builds. Thanks, -Alex On 9/1/18, 10:43 AM, "Harbs" <[email protected]> wrote: Yes. Royale-extras exists to supplement Royale in up-stream or down-stream code which is not part of our official project. The only thing there right now is a fork of closure-compiler with patched extern files. Ideally any externs which need patching should be patched in this org. I see you’re not a member of royale-extras. I just sent you an invite. > On Sep 1, 2018, at 2:44 AM, Alex Harui <[email protected]> wrote: > > I found some time to look into the Maven build on builds.a.o. > > AFAICT, the reason it is working for us locally but not on builds.a.o is because the google_maps build is trying to call Git to patch the externs file. On builds.a.o, it is unable to find git. My theory is that some configuration changed and Git is no longer in the path. > > While we could ask infra what the path is to Git, or figure it out ourselves, in looking at old emails, it appears that a royale-extras repo exists to try to eliminate the need to patch these externs. Can someone confirm this? I tried just skipping the patch step and the build failed, so it appears that what is in royale-extras for google_maps is "pre-patch". This implies that one possible solution is to update royale-extras with the post-patch extern. This would be preferable, IMO, since it would be less config dependent and thus more likely to work on builds.a.o and elsewhere. Can someone confirm this is the case, and better yet, make the required changes? > > That said, if I am right and updating google_maps in royale-extras and removing the patch step fixes the build, my next question is about how we are handling the code in royale-extras. Is this an ASF thing, someone's personal thing, something else? We may need to review our LICENSE/NOTICE files? > > Thanks, > -Alex >
