Hi,
this is my test of a complete build with maven that worked successfully:
I tried to remove my repository folder content completely to make all from
scratch, and remove personal maven servers in my settings.xml file to
ensure I'm in the most generic case (and don't have access to things I
could have in my server like Flash Player).
Conclusions:
1.- Compiler
I need to add Greg proposed dependency in "compiler/pom.xml"
<dependency>
<groupId>com.adobe.flash.framework</groupId>
<artifactId>playerglobal</artifactId>
<version>${flash.version}</version>
<type>swc</type>
<scope>test</scope>
</dependency>
without this running
mvn -s settings-template.xml clean install
fails to run Flash Player Debugger
but with that dependency maven asks to download flash player and all works
perfectly and build succeed. So without this people running without
-DskipTests will get a problem when the process try to run tests.
Note: I don't need to do this step:
mvn -s settings-template.xml clean install -P utils
If nobody objects, I'll remove it in the wiki since compiler since seems a
useless step in the current situation, and great to be able to simplify
process a bit
2.- TypeDefs
Nothing changes here
3.- ASJS repo
The change is to update the command line to this:
mvn -s settings-template.xml clean install -Pgenerate-swcs-for-swf
(add the profile part generate-swcs-for-swf)
for first time build with maven
I tried to comment the extension (asked by Greg)
<extension>
<groupId>org.apache.flex.utilities.converter</groupId>
<artifactId>flex-sdk-converter-maven-extension</artifactId>
<version>1.0.0-SNAPSHOT</version>
</extension>
but doing this makes build fail since it doesn't ask about flash player and
the error is the same I got and the start of this thread (like running
without profile option)
If no body objects, I'll update:
1.- compiler/pom.xml with dependency
2.- wiki with changes commented here
thanks
El mié., 22 may. 2019 a las 12:04, Carlos Rovira (<[email protected]>)
escribió:
> Hi,
>
> I was able to use a profile I found, I think maybe Alex prepared this
> profile for this initial case?
>
> mvn -s settings-template.xml clean install -Pgenerate-swcs-for-swf
>
> So I'll update wiki adding this: -Pgenerate-swcs-for-swf
>
> ok?
>
>
> El mié., 22 may. 2019 a las 11:01, Carlos Rovira (<[email protected]>)
> escribió:
>
>> Hi Greg,
>>
>>
>> El mié., 22 may. 2019 a las 6:35, Greg Dove (<[email protected]>)
>> escribió:
>>
>>> Two things as follow up:
>>> (1)
>>> Actually, going back to that last comment about playerglobal in the
>>> compiler... It was only working for me because I had reference to a
>>> specific repository that hosts the playerglobal.swcs in my
>>> m2/settings.xml.
>>>
>>> It was also possible to get it working in a fresh build by adding a
>>> repository to the top level compiler pom.xml.
>>> But I guess there is not an official maven distribution from Adobe for
>>> these swcs... Alex do you have any insight you can share about this?
>>> Will it be available via Adobe, I guess is my question, i.e. has anyone
>>> asked internally if Adobe would be ok to host the the playerglobals at:
>>> https://repo.adobe.com/nexus/content/groups/public
>>>
>>>
>> Seems player global is available here?
>> https://mvnrepository.com/artifact/com.adobe.flash.framework/playerglobal
>> Could we use this?
>>
>>
>>> (2)
>>> Beyond that I was eventually able to repro Carlos' issue on windows. This
>>> was a tough one to find.
>>> I believe the build issue is related to this commit:
>>>
>>> https://github.com/apache/royale-asjs/commit/a89b07a60179f0568d2441445f1396e160a13ae5
>>> I got it to work again by changing this value from from true to false:
>>>
>>> https://github.com/apache/royale-asjs/blob/a89b07a60179f0568d2441445f1396e160a13ae5/pom.xml#L62
>>>
>>> I see in a later commit comment something about this being optional.
>>> Alex,
>>> what did you intend the default to be, is it possible it should be the
>>> opposite in that parent pom (which fixes the build for me)?
>>>
>>>
>>>
>> Thanks for finding this, I'm going to try setting it to false, and report
>> if this works with an empty repo
>> If that works, we should do some change to make it easy for new comers,
>> maybe updating the instruction provided here:
>> https://github.com/apache/royale-asjs/wiki/Build-Apache-Royale-with-Maven
>>
>> mvn -s settings-template.xml clean install
>>
>> with some additional part -DskipAs=false or something (don't know right
>> now, I'll need to check how to do this on command line)
>>
>> Thanks Greg, for finding this :)
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
