Hi Alex, El jue., 23 may. 2019 a las 3:49, Alex Harui (<[email protected]>) escribió:
> Before we go too far in any one direction, I may not be able to respond > fully to this thread today as there seems to be a lot to catch up on, but > let me try to summarize the goals of the Maven build. > > 1) There are some helper jars (compiler-build-tools and > compiler-jburg-types). They are built by the "utils" profile. They > haven't changed in develop, but they will change in 0.9.6. They've been > changed in the release_practice branch. So folks will need to use the > "utils" profile whenever we (rarely) change those jars. > > Ok, so we should put in wiki that utils profile is needed for that case, but not for "initial" build case. I'm worried to try to simplify instructions and process to minumun needs to avoid new comers confusion. So, I'll mention utils profile as a special case to execute when needed. > 2) Adobe will probably never publish official playerglobal on Maven. > There is a whole bunch of logic in the Mavenizer to address licensing > acceptance issues. > For what we discussed in the thread, seems playerglobal is already on maven official repos, so my guest is we are served with that and don't need adobe host it in a maven repo. > > 3) IIRC, the most recent changes were to allow the Maven build to work > without requiring SWF versions of artifacts and probably > playerglobal/airglobal. So, adding hard requirements to playerglobal will > defeat this capability unless those dependencies are in the appropriate > Maven profile. > Right now we need to do this: mvn -s settings-template.xml clean install -Pgenerate-swcs-for-swf so this means something is not working ok in a clean environment for first build/install? For now, the current instructions works, but if that's the case, we should try to fix this in the future, although seems this is not urgent while people is capable of build Royale in the current way. > > 4) The CI builds (builds.a.o and apachroyalecibuild) are good reference > examples of Maven building things correctly on Windows. You can compare > your setup and console output to those builds. > I was building without problem and still can build without problem. My concern was for the case people tries to build maven for the first time, and was where I found problems. This problems are as well not reproduced in machines that are already working, since they pass the initial setup. > > 5) There might be some assumption that airglobal and/or playerglobal exist > to determine whether the build is going to try to output SWF versions of > the artifacts or not. > > 6) The default, IIRC, is to not require airglobal/playerglobal and build a > JS-Only set of artifacts similar to how it is done in the Ant builds. > So, this wiki walkthrough: https://github.com/apache/royale-asjs/wiki/Build-Apache-Royale-with-Maven is describing whole process without differentiation. can be updated to build with maven SWF/JS and in the other hand only JS? I think the actual page description us for SWF/JS, and I personally never try / or know how to build just JS, what would be very interesting since many people will really only build for JS, and if sometime in the future we have other interesting target like WebAsembly, will want to add it and build JS/WEBASM > > Unfortunately, that means that most of the ideas I've read while skimming > over this thread so far may not be correct. > I think you have to have in mind that we all was working right with our current environment and that the problem comes from try to start from scratch. Subsequents builds instructions are simpler since requires shorter instructions. You should try to rename your "repository" folder and create a new one and try to build with maven to see what you find and if we can improve actual findings. Thanks Alex! Carlos > > HTH, > -Alex > > On 5/22/19, 12:17 PM, "Greg Dove" <[email protected]> wrote: > > Hi Carlos, > > Seems like you have made great progress - well done! > > re: > > "Seems player global is available here? > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmvnrepository.com%2Fartifact%2Fcom.adobe.flash.framework%2Fplayerglobal&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755181756&sdata=m7eGCEle51O%2BT3Yri9Ob2XWoEsLHcNNx0mVXcMyMRhI%3D&reserved=0 > Could we use this? " > > I used that one as well yesterday, but iiuc that is actually at: > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Frepository.jspresso.org%2Fmaven2%2F&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=%2BABLeHwUx9DEep%2B6qGDRt7oYxKAUVmSw6NZtB%2FDrqX8%3D&reserved=0 > It did not work under https and I don't know what status that has in > terms > of its validity etc. Maybe it's ok, but I would assume something > official > from Adobe would be better (if possible). > > For the extension.xml inside .mvn folder I did not try commenting that > it > in the compiler build. I only did that in the asjs build and it did not > affect things. Maybe it does something, but I only saw warnings. > > > > > On Thu, May 23, 2019 at 3:09 AM Carlos Rovira <[email protected] > > > wrote: > > > Hi, > > > > this is my test of a complete build with maven that worked > successfully: > > > > I tried to remove my repository folder content completely to make > all from > > scratch, and remove personal maven servers in my settings.xml file to > > ensure I'm in the most generic case (and don't have access to things > I > > could have in my server like Flash Player). > > > > Conclusions: > > > > 1.- Compiler > > > > I need to add Greg proposed dependency in "compiler/pom.xml" > > > > <dependency> > > <groupId>com.adobe.flash.framework</groupId> > > <artifactId>playerglobal</artifactId> > > <version>${flash.version}</version> > > <type>swc</type> > > <scope>test</scope> > > </dependency> > > > > without this running > > > > mvn -s settings-template.xml clean install > > > > fails to run Flash Player Debugger > > but with that dependency maven asks to download flash player and all > works > > perfectly and build succeed. So without this people running without > > -DskipTests will get a problem when the process try to run tests. > > > > Note: I don't need to do this step: > > > > mvn -s settings-template.xml clean install -P utils > > If nobody objects, I'll remove it in the wiki since compiler since > seems a > > useless step in the current situation, and great to be able to > simplify > > process a bit > > > > 2.- TypeDefs > > > > Nothing changes here > > > > 3.- ASJS repo > > > > The change is to update the command line to this: > > > > mvn -s settings-template.xml clean install -Pgenerate-swcs-for-swf > > > > (add the profile part generate-swcs-for-swf) > > > > for first time build with maven > > > > I tried to comment the extension (asked by Greg) > > > > <extension> > > <groupId>org.apache.flex.utilities.converter</groupId> > > <artifactId>flex-sdk-converter-maven-extension</artifactId> > > <version>1.0.0-SNAPSHOT</version> > > </extension> > > > > but doing this makes build fail since it doesn't ask about flash > player and > > the error is the same I got and the start of this thread (like > running > > without profile option) > > > > If no body objects, I'll update: > > > > 1.- compiler/pom.xml with dependency > > 2.- wiki with changes commented here > > > > thanks > > > > > > > > > > > > El mié., 22 may. 2019 a las 12:04, Carlos Rovira (< > [email protected] > > >) > > escribió: > > > > > Hi, > > > > > > I was able to use a profile I found, I think maybe Alex prepared > this > > > profile for this initial case? > > > > > > mvn -s settings-template.xml clean install -Pgenerate-swcs-for-swf > > > > > > So I'll update wiki adding this: -Pgenerate-swcs-for-swf > > > > > > ok? > > > > > > > > > El mié., 22 may. 2019 a las 11:01, Carlos Rovira (< > > [email protected]>) > > > escribió: > > > > > >> Hi Greg, > > >> > > >> > > >> El mié., 22 may. 2019 a las 6:35, Greg Dove (<[email protected] > >) > > >> escribió: > > >> > > >>> Two things as follow up: > > >>> (1) > > >>> Actually, going back to that last comment about playerglobal in > the > > >>> compiler... It was only working for me because I had reference > to a > > >>> specific repository that hosts the playerglobal.swcs in my > > >>> m2/settings.xml. > > >>> > > >>> It was also possible to get it working in a fresh build by > adding a > > >>> repository to the top level compiler pom.xml. > > >>> But I guess there is not an official maven distribution from > Adobe for > > >>> these swcs... Alex do you have any insight you can share about > this? > > >>> Will it be available via Adobe, I guess is my question, i.e. has > anyone > > >>> asked internally if Adobe would be ok to host the the > playerglobals at: > > >>> > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepo.adobe.com%2Fnexus%2Fcontent%2Fgroups%2Fpublic&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=tZcTmWIy5jK9%2BAr8fnW5Vd5%2F%2FI%2F5fUi14dPuR9iTL78%3D&reserved=0 > > >>> > > >>> > > >> Seems player global is available here? > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmvnrepository.com%2Fartifact%2Fcom.adobe.flash.framework%2Fplayerglobal&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=KE5AziHyYEvGt6t0jKdktrsrIsrXEPf7aTqlKmkLM9k%3D&reserved=0 > > >> Could we use this? > > >> > > >> > > >>> (2) > > >>> Beyond that I was eventually able to repro Carlos' issue on > windows. > > This > > >>> was a tough one to find. > > >>> I believe the build issue is related to this commit: > > >>> > > >>> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fcommit%2Fa89b07a60179f0568d2441445f1396e160a13ae5&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=2VkBkHR%2F9NUR1ORx4wFW7MfaAXYwIWJ9C8Up8paYl3U%3D&reserved=0 > > >>> I got it to work again by changing this value from from true to > false: > > >>> > > >>> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Fa89b07a60179f0568d2441445f1396e160a13ae5%2Fpom.xml%23L62&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=JOiuwscsTqccF7NVs9rH5olCG0dPHNRHN0IVDl6PN3U%3D&reserved=0 > > >>> > > >>> I see in a later commit comment something about this being > optional. > > >>> Alex, > > >>> what did you intend the default to be, is it possible it should > be the > > >>> opposite in that parent pom (which fixes the build for me)? > > >>> > > >>> > > >>> > > >> Thanks for finding this, I'm going to try setting it to false, and > > report > > >> if this works with an empty repo > > >> If that works, we should do some change to make it easy for new > comers, > > >> maybe updating the instruction provided here: > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fwiki%2FBuild-Apache-Royale-with-Maven&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=ynk2%2B5FKUpU%2FpKBTqvGdji1bvYFKmHz1YVO%2FQ5gJMAE%3D&reserved=0 > > >> > > >> mvn -s settings-template.xml clean install > > >> > > >> with some additional part -DskipAs=false or something (don't know > right > > >> now, I'll need to check how to do this on command line) > > >> > > >> Thanks Greg, for finding this :) > > >> > > >> -- > > >> Carlos Rovira > > >> > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=WZJcGE3HCNP2KQx%2FqNzRUkfsex0Xpyczq02m0EhlNzQ%3D&reserved=0 > > >> > > >> > > > > > > -- > > > Carlos Rovira > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=WZJcGE3HCNP2KQx%2FqNzRUkfsex0Xpyczq02m0EhlNzQ%3D&reserved=0 > > > > > > > > > > -- > > Carlos Rovira > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca56f03d9d16e4b1511e708d6deea2df7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636941494755191755&sdata=WZJcGE3HCNP2KQx%2FqNzRUkfsex0Xpyczq02m0EhlNzQ%3D&reserved=0 > > > > > -- Carlos Rovira http://about.me/carlosrovira
