I think I'm moving forward to some direction - We will see if I success with that ;)
wt., 29 paź 2019 o 09:36 Piotr Zarzycki <[email protected]> napisał(a): > A I understand I need to use that token probably -> JSRoyaleEmitterTokens. > CLOSURE_FUNCTION_NAME.getToken() > > wt., 29 paź 2019 o 09:31 Piotr Zarzycki <[email protected]> > napisał(a): > >> I really don't know what you are saying, but I'm trying to figure out. >> Anyone can point me what does that mean ? >> >> pon., 28 paź 2019 o 19:46 Alex Harui <[email protected]> >> napisał(a): >> >>> The compiler should probably generate a call to Language.closure that >>> wraps the function. I won't have time to work on it today, so feel free >>> to make the changes to my last commit. >>> >>> -Alex >>> >>> On 10/28/19, 11:31 AM, "Piotr Zarzycki" <[email protected]> >>> wrote: >>> >>> To this one from Alina's example -> >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fuxwvf&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=RQloqMjMaPLKZq62T7ftor%2BLHFYSPhI91HRGfwyUG7g%3D&reserved=0 >>> . I >>> have attached full example in the issue. >>> >>> pon., 28 paź 2019 o 19:29 Alex Harui <[email protected]> >>> napisał(a): >>> >>> > I do not know what formatter you are referring to. >>> > >>> > On 10/28/19, 11:26 AM, "Piotr Zarzycki" <[email protected] >>> > >>> > wrote: >>> > >>> > Hi Alex, >>> > >>> > It looks like now function is being called properly, but >>> formatter >>> > which is >>> > declared in <fx:Declarations> is undefined. Probably we could >>> make some >>> > workaround, but from Alina's perspective it is a different >>> story. I'm >>> > wondering why it is undefined, since it is in Declarations... >>> > >>> > Thanks, >>> > Piotr >>> > >>> > pon., 28 paź 2019 o 17:59 Alex Harui <[email protected] >>> > >>> > napisał(a): >>> > >>> > > I just pushed changes to the compiler that should generate >>> the right >>> > > output. Give it a try. >>> > > >>> > > -Alex >>> > > >>> > > On 10/28/19, 8:32 AM, "Alex Harui" <[email protected]> >>> wrote: >>> > > >>> > > I will try to fix the compiler. >>> > > >>> > > The only thing I saw in the commit that didn't look >>> right was >>> > > assigning the itemrenderer's data to the result of the >>> > labelFunction. I >>> > > don't think Flex ever replaced the data property, I think >>> the text to >>> > > display was computed elsewhere. >>> > > >>> > > -Alex >>> > > >>> > > On 10/28/19, 12:20 AM, "Piotr Zarzycki" < >>> > [email protected]> >>> > > wrote: >>> > > >>> > > Alex, >>> > > >>> > > Will you look into compiler issue ? >>> > > >>> > > pon., 28 paź 2019 o 07:58 Piotr Zarzycki < >>> > > [email protected]> >>> > > napisał(a): >>> > > >>> > > > What do you think about implementation ? Cause I >>> would >>> > like to >>> > > merge it >>> > > > this week, even if there is compiler issue. >>> > > > >>> > > > pon., 28 paź 2019 o 07:12 Alex Harui >>> > <[email protected]> >>> > > > napisał(a): >>> > > > >>> > > >> Yes, looks like the compiler is not handling >>> attributes >>> > of type >>> > > Function >>> > > >> in MXML correctly. >>> > > >> >>> > > >> On 10/27/19, 7:56 AM, "Piotr Zarzycki" < >>> > > [email protected]> >>> > > >> wrote: >>> > > >> >>> > > >> Hi Alex, >>> > > >> >>> > > >> I have pushed implementation and described it >>> here >>> > [1]. >>> > > Take a look >>> > > >> and let >>> > > >> me know if it's ok. It doesn't work - I'm >>> thinking >>> > that it >>> > > may be >>> > > >> some kind >>> > > >> of compiler issue. >>> > > >> >>> > > >> [1] >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472%23issuecomment-546701359&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=%2FcPrxFYvfSMMA9NbZmNGJkos3vqIREF11t51bzUxoUI%3D&reserved=0 >>> > > >> >>> > > >> Thanks, >>> > > >> Piotr >>> > > >> >>> > > >> wt., 22 paź 2019 o 19:31 Alex Harui >>> > > <[email protected]> >>> > > >> napisał(a): >>> > > >> >>> > > >> > The emulation is currently only promising >>> to support >>> > > public APIs. >>> > > >> If it >>> > > >> > turns out that lots of folks have >>> subclasses that >>> > call >>> > > >> makeRowsAndColumns >>> > > >> > then we'll emulate it. >>> > > >> > >>> > > >> > I recommend trying to extend the labelField >>> pattern >>> > in >>> > > Basic. IMO, >>> > > >> the >>> > > >> > labelField pattern is: >>> > > >> > -"labelField" property on top-level >>> component (TLC) >>> > > passes to model >>> > > >> > -Factory passes labelField property from >>> model to >>> > > itemRenderer >>> > > >> > -ItemRenderer decides what to do with >>> labelFunction >>> > > >> > >>> > > >> > So, in keeping with PAYG, whenever we get >>> around to >>> > > supporting >>> > > >> > labelFunction in Basic, we'd add a code to >>> > subclasses of >>> > > the TLCs, >>> > > >> the >>> > > >> > models, the factories, and the item >>> renderers. >>> > > >> > >>> > > >> > I think that's a different flow from Flex, >>> but >>> > should be >>> > > sufficient >>> > > >> unless >>> > > >> > folks are relying on >>> labelFunction/labelField in the >>> > > .text property >>> > > >> of the >>> > > >> > listData structures. If you run into that >>> then we >>> > can >>> > > discuss how >>> > > >> to >>> > > >> > emulate the listData structure. >>> > > >> > >>> > > >> > My 2 cents, >>> > > >> > -Alex >>> > > >> > >>> > > >> > On 10/22/19, 4:15 AM, "Yishay Weiss" < >>> > > [email protected]> >>> > > >> wrote: >>> > > >> > >>> > > >> > In my opinion it’s easier and more >>> elegant to >>> > add the >>> > > missing >>> > > >> > functionality in a bead (e.g. >>> > > >> > >>> > > >>> DataItemRendererFactoryForICollectionViewAdvancedDataGridData ) >>> > > >> rather than >>> > > >> > reproduce Flex’s class hierarchy. The only >>> reason >>> > to do >>> > > the latter >>> > > >> would be >>> > > >> > to make code that depends on a particular >>> class >>> > hierarchy >>> > > (is >>> > > >> operator, >>> > > >> > casting) run correctly. >>> > > >> > >>> > > >> > My approach would be to add the >>> functionality >>> > in a >>> > > bead, but >>> > > >> make that >>> > > >> > bead reusable so that it can be referenced >>> from >>> > > AdvancedListBase in >>> > > >> case >>> > > >> > that’s necessary. >>> > > >> > >>> > > >> > I hope that makes sense. >>> > > >> > >>> > > >> > ________________________________ >>> > > >> > From: Piotr Zarzycki < >>> [email protected] >>> > > >>> > > >> > Sent: Tuesday, October 22, 2019 >>> 12:48:52 PM >>> > > >> > To: [email protected] < >>> > [email protected]> >>> > > >> > Subject: Emulation of labelFunction in >>> ADG >>> > > >> > >>> > > >> > Hi Guys, >>> > > >> > >>> > > >> > I'm working on fixing issue [1]. >>> labelFunction >>> > wasn't >>> > > emulated >>> > > >> at all >>> > > >> > so >>> > > >> > I'm trying to figure out how to add >>> that. >>> > > >> > >>> > > >> > I checked deeper Flex code and it looks >>> like >>> > launching >>> > > >> labelFunction is >>> > > >> > starting to happen during row creation. >>> There is >>> > > >> > function >>> makeRowsAndColumnsWithExtraRows in >>> > > AdvancedListBase >>> > > >> where >>> > > >> > everything is starting. >>> > > >> > >>> > > >> > My question is - should I go and start >>> copying >>> > code >>> > > and classes >>> > > >> to fill >>> > > >> > that gap or rather place launching that >>> > formatting in >>> > > >> > >>> > > >>> DataItemRendererFactoryForICollectionViewAdvancedDataGridData >>> > > >> > where we are creating and setup >>> renderer ? What >>> > is >>> > > the general >>> > > >> > approach. >>> > > >> > >>> > > >> > [1] >>> > > >> > >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=nCAgtOp%2Fi8vQuOsXowIuJUj%2FiIPMPNCmJAAFDMTq%2Bh8%3D&reserved=0 >>> > > >> > >>> > > >> > Thanks, >>> > > >> > -- >>> > > >> > >>> > > >> > Piotr Zarzycki >>> > > >> > >>> > > >> > Patreon: * >>> > > >> > >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > >> > < >>> > > >> > >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > >> > >* >>> > > >> > >>> > > >> > >>> > > >> > >>> > > >> >>> > > >> -- >>> > > >> >>> > > >> Piotr Zarzycki >>> > > >> >>> > > >> Patreon: * >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > >> < >>> > > >> >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > >> >* >>> > > >> >>> > > >> >>> > > >> >>> > > > >>> > > > -- >>> > > > >>> > > > Piotr Zarzycki >>> > > > >>> > > > Patreon: * >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > > < >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075706257&sdata=Q7zTEZA7iMsLeomyOO%2FIgEAS898hPPNW6sBd0JWXDiE%3D&reserved=0 >>> > > >* >>> > > > >>> > > >>> > > >>> > > -- >>> > > >>> > > Piotr Zarzycki >>> > > >>> > > Patreon: * >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> > > < >>> > > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> > > >* >>> > > >>> > > >>> > > >>> > > >>> > > >>> > >>> > -- >>> > >>> > Piotr Zarzycki >>> > >>> > Patreon: * >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> > < >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> > >* >>> > >>> > >>> > >>> >>> -- >>> >>> Piotr Zarzycki >>> >>> Patreon: * >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> < >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C98d199babf184f7574ca08d75bd51677%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078843075716255&sdata=Ws%2F1aKdnCZiP8c46SCUMf7h%2F2NGuyb6DM5YmJBrJHS0%3D&reserved=0 >>> >* >>> >>> >>> >> >> -- >> >> Piotr Zarzycki >> >> Patreon: *https://www.patreon.com/piotrzarzycki >> <https://www.patreon.com/piotrzarzycki>* >> > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
