Hi Piotr,
Yes, that's pretty much the right change. I made a minor tweak to it just now
so the integration tests will pass. We need to set up a CI job for integration
tests someday.
-Alex
On 10/29/19, 2:36 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote:
Alex,
It looks like I was able to figure out how to do that. Thanks for pushing
me out. Please review whether I didn't break anything. I will merge my
branch to develop.
Thanks,
Piotr
wt., 29 paź 2019 o 09:57 Piotr Zarzycki <piotrzarzyck...@gmail.com>
napisał(a):
> I think I'm moving forward to some direction - We will see if I success
> with that ;)
>
> wt., 29 paź 2019 o 09:36 Piotr Zarzycki <piotrzarzyck...@gmail.com>
> napisał(a):
>
>> A I understand I need to use that token probably ->
>> JSRoyaleEmitterTokens.CLOSURE_FUNCTION_NAME.getToken()
>>
>> wt., 29 paź 2019 o 09:31 Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> napisał(a):
>>
>>> I really don't know what you are saying, but I'm trying to figure out.
>>> Anyone can point me what does that mean ?
>>>
>>> pon., 28 paź 2019 o 19:46 Alex Harui <aha...@adobe.com.invalid>
>>> napisał(a):
>>>
>>>> The compiler should probably generate a call to Language.closure that
>>>> wraps the function. I won't have time to work on it today, so feel
free
>>>> to make the changes to my last commit.
>>>>
>>>> -Alex
>>>>
>>>> On 10/28/19, 11:31 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com>
>>>> wrote:
>>>>
>>>> To this one from Alina's example ->
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fuxwvf&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607504464&sdata=lFqHLgFEBpDvyU3%2FEJQYyleeQAO4qDcQfuvAaW5IHCE%3D&reserved=0
>>>> . I
>>>> have attached full example in the issue.
>>>>
>>>> pon., 28 paź 2019 o 19:29 Alex Harui <aha...@adobe.com.invalid>
>>>> napisał(a):
>>>>
>>>> > I do not know what formatter you are referring to.
>>>> >
>>>> > On 10/28/19, 11:26 AM, "Piotr Zarzycki" <
>>>> piotrzarzyck...@gmail.com>
>>>> > wrote:
>>>> >
>>>> > Hi Alex,
>>>> >
>>>> > It looks like now function is being called properly, but
>>>> formatter
>>>> > which is
>>>> > declared in <fx:Declarations> is undefined. Probably we could
>>>> make some
>>>> > workaround, but from Alina's perspective it is a different
>>>> story. I'm
>>>> > wondering why it is undefined, since it is in Declarations...
>>>> >
>>>> > Thanks,
>>>> > Piotr
>>>> >
>>>> > pon., 28 paź 2019 o 17:59 Alex Harui
<aha...@adobe.com.invalid
>>>> >
>>>> > napisał(a):
>>>> >
>>>> > > I just pushed changes to the compiler that should generate
>>>> the right
>>>> > > output. Give it a try.
>>>> > >
>>>> > > -Alex
>>>> > >
>>>> > > On 10/28/19, 8:32 AM, "Alex Harui"
<aha...@adobe.com.INVALID>
>>>> wrote:
>>>> > >
>>>> > > I will try to fix the compiler.
>>>> > >
>>>> > > The only thing I saw in the commit that didn't look
>>>> right was
>>>> > > assigning the itemrenderer's data to the result of the
>>>> > labelFunction. I
>>>> > > don't think Flex ever replaced the data property, I think
>>>> the text to
>>>> > > display was computed elsewhere.
>>>> > >
>>>> > > -Alex
>>>> > >
>>>> > > On 10/28/19, 12:20 AM, "Piotr Zarzycki" <
>>>> > piotrzarzyck...@gmail.com>
>>>> > > wrote:
>>>> > >
>>>> > > Alex,
>>>> > >
>>>> > > Will you look into compiler issue ?
>>>> > >
>>>> > > pon., 28 paź 2019 o 07:58 Piotr Zarzycki <
>>>> > > piotrzarzyck...@gmail.com>
>>>> > > napisał(a):
>>>> > >
>>>> > > > What do you think about implementation ? Cause I
>>>> would
>>>> > like to
>>>> > > merge it
>>>> > > > this week, even if there is compiler issue.
>>>> > > >
>>>> > > > pon., 28 paź 2019 o 07:12 Alex Harui
>>>> > <aha...@adobe.com.invalid>
>>>> > > > napisał(a):
>>>> > > >
>>>> > > >> Yes, looks like the compiler is not handling
>>>> attributes
>>>> > of type
>>>> > > Function
>>>> > > >> in MXML correctly.
>>>> > > >>
>>>> > > >> On 10/27/19, 7:56 AM, "Piotr Zarzycki" <
>>>> > > piotrzarzyck...@gmail.com>
>>>> > > >> wrote:
>>>> > > >>
>>>> > > >> Hi Alex,
>>>> > > >>
>>>> > > >> I have pushed implementation and described
>>>> it here
>>>> > [1].
>>>> > > Take a look
>>>> > > >> and let
>>>> > > >> me know if it's ok. It doesn't work - I'm
>>>> thinking
>>>> > that it
>>>> > > may be
>>>> > > >> some kind
>>>> > > >> of compiler issue.
>>>> > > >>
>>>> > > >> [1]
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472%23issuecomment-546701359&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607504464&sdata=CSyeYTf7VNVm8rzRIt2U3cXfnO5mKi2QiKyLMZ5Nf4Q%3D&reserved=0
>>>> > > >>
>>>> > > >> Thanks,
>>>> > > >> Piotr
>>>> > > >>
>>>> > > >> wt., 22 paź 2019 o 19:31 Alex Harui
>>>> > > <aha...@adobe.com.invalid>
>>>> > > >> napisał(a):
>>>> > > >>
>>>> > > >> > The emulation is currently only promising
>>>> to support
>>>> > > public APIs.
>>>> > > >> If it
>>>> > > >> > turns out that lots of folks have
>>>> subclasses that
>>>> > call
>>>> > > >> makeRowsAndColumns
>>>> > > >> > then we'll emulate it.
>>>> > > >> >
>>>> > > >> > I recommend trying to extend the
>>>> labelField pattern
>>>> > in
>>>> > > Basic. IMO,
>>>> > > >> the
>>>> > > >> > labelField pattern is:
>>>> > > >> > -"labelField" property on top-level
>>>> component (TLC)
>>>> > > passes to model
>>>> > > >> > -Factory passes labelField property from
>>>> model to
>>>> > > itemRenderer
>>>> > > >> > -ItemRenderer decides what to do with
>>>> labelFunction
>>>> > > >> >
>>>> > > >> > So, in keeping with PAYG, whenever we get
>>>> around to
>>>> > > supporting
>>>> > > >> > labelFunction in Basic, we'd add a code to
>>>> > subclasses of
>>>> > > the TLCs,
>>>> > > >> the
>>>> > > >> > models, the factories, and the item
>>>> renderers.
>>>> > > >> >
>>>> > > >> > I think that's a different flow from Flex,
>>>> but
>>>> > should be
>>>> > > sufficient
>>>> > > >> unless
>>>> > > >> > folks are relying on
>>>> labelFunction/labelField in the
>>>> > > .text property
>>>> > > >> of the
>>>> > > >> > listData structures. If you run into that
>>>> then we
>>>> > can
>>>> > > discuss how
>>>> > > >> to
>>>> > > >> > emulate the listData structure.
>>>> > > >> >
>>>> > > >> > My 2 cents,
>>>> > > >> > -Alex
>>>> > > >> >
>>>> > > >> > On 10/22/19, 4:15 AM, "Yishay Weiss" <
>>>> > > yishayj...@hotmail.com>
>>>> > > >> wrote:
>>>> > > >> >
>>>> > > >> > In my opinion it’s easier and more
>>>> elegant to
>>>> > add the
>>>> > > missing
>>>> > > >> > functionality in a bead (e.g.
>>>> > > >> >
>>>> > >
>>>> DataItemRendererFactoryForICollectionViewAdvancedDataGridData )
>>>> > > >> rather than
>>>> > > >> > reproduce Flex’s class hierarchy. The only
>>>> reason
>>>> > to do
>>>> > > the latter
>>>> > > >> would be
>>>> > > >> > to make code that depends on a particular
>>>> class
>>>> > hierarchy
>>>> > > (is
>>>> > > >> operator,
>>>> > > >> > casting) run correctly.
>>>> > > >> >
>>>> > > >> > My approach would be to add the
>>>> functionality
>>>> > in a
>>>> > > bead, but
>>>> > > >> make that
>>>> > > >> > bead reusable so that it can be referenced
>>>> from
>>>> > > AdvancedListBase in
>>>> > > >> case
>>>> > > >> > that’s necessary.
>>>> > > >> >
>>>> > > >> > I hope that makes sense.
>>>> > > >> >
>>>> > > >> > ________________________________
>>>> > > >> > From: Piotr Zarzycki <
>>>> piotrzarzyck...@gmail.com
>>>> > >
>>>> > > >> > Sent: Tuesday, October 22, 2019
>>>> 12:48:52 PM
>>>> > > >> > To: dev@royale.apache.org <
>>>> > dev@royale.apache.org>
>>>> > > >> > Subject: Emulation of labelFunction in
>>>> ADG
>>>> > > >> >
>>>> > > >> > Hi Guys,
>>>> > > >> >
>>>> > > >> > I'm working on fixing issue [1].
>>>> labelFunction
>>>> > wasn't
>>>> > > emulated
>>>> > > >> at all
>>>> > > >> > so
>>>> > > >> > I'm trying to figure out how to add
>>>> that.
>>>> > > >> >
>>>> > > >> > I checked deeper Flex code and it
>>>> looks like
>>>> > launching
>>>> > > >> labelFunction is
>>>> > > >> > starting to happen during row
>>>> creation. There is
>>>> > > >> > function
>>>> makeRowsAndColumnsWithExtraRows in
>>>> > > AdvancedListBase
>>>> > > >> where
>>>> > > >> > everything is starting.
>>>> > > >> >
>>>> > > >> > My question is - should I go and start
>>>> copying
>>>> > code
>>>> > > and classes
>>>> > > >> to fill
>>>> > > >> > that gap or rather place launching
that
>>>> > formatting in
>>>> > > >> >
>>>> > >
>>>> DataItemRendererFactoryForICollectionViewAdvancedDataGridData
>>>> > > >> > where we are creating and setup
>>>> renderer ? What
>>>> > is
>>>> > > the general
>>>> > > >> > approach.
>>>> > > >> >
>>>> > > >> > [1]
>>>> > > >> >
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607504464&sdata=pl0FiYLsMG%2By0FG56wx4c1kmENXQF4V96coD4xvRHsM%3D&reserved=0
>>>> > > >> >
>>>> > > >> > Thanks,
>>>> > > >> > --
>>>> > > >> >
>>>> > > >> > Piotr Zarzycki
>>>> > > >> >
>>>> > > >> > Patreon: *
>>>> > > >> >
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >> > <
>>>> > > >> >
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >> > >*
>>>> > > >> >
>>>> > > >> >
>>>> > > >> >
>>>> > > >>
>>>> > > >> --
>>>> > > >>
>>>> > > >> Piotr Zarzycki
>>>> > > >>
>>>> > > >> Patreon: *
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >> <
>>>> > > >>
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >> >*
>>>> > > >>
>>>> > > >>
>>>> > > >>
>>>> > > >
>>>> > > > --
>>>> > > >
>>>> > > > Piotr Zarzycki
>>>> > > >
>>>> > > > Patreon: *
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > > <
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >*
>>>> > > >
>>>> > >
>>>> > >
>>>> > > --
>>>> > >
>>>> > > Piotr Zarzycki
>>>> > >
>>>> > > Patreon: *
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > <
>>>> > >
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > > >*
>>>> > >
>>>> > >
>>>> > >
>>>> > >
>>>> > >
>>>> >
>>>> > --
>>>> >
>>>> > Piotr Zarzycki
>>>> >
>>>> > Patreon: *
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607514461&sdata=MXmD%2BuOQpaexs3raaQKPsMeOsSfgcoEiw9fA5%2FjNaqA%3D&reserved=0
>>>> > <
>>>> >
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>>>> > >*
>>>> >
>>>> >
>>>> >
>>>>
>>>> --
>>>>
>>>> Piotr Zarzycki
>>>>
>>>> Patreon: *
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>>>> <
>>>>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>>>> >*
>>>>
>>>>
>>>>
>>>
>>> --
>>>
>>> Piotr Zarzycki
>>>
>>> Patreon:
*https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>>>
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0>*
>>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> Patreon:
*https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>>
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0>*
>>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon:
*https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
>
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0>*
>
--
Piotr Zarzycki
Patreon:
*https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce7545c0fa2a142acba8b08d75c5367bc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637079385607524454&sdata=8IqQXQCuslrxBci9Lfba5h2VQGUB1m%2F%2B1VV6x9PNRUs%3D&reserved=0>*
