Vote: +1

Package
https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/apache-royale-0.9.7-src.zip
Java 1.8
OS: Windows 10 amd64 10.0
Source kit signatures match: y
Source kit builds: y
README is ok: y
RELEASE_NOTES is ok: y
NOTICE is ok: y
LICENSE is ok: y
No unapproved licenses or archives: y
No unapproved binaries: y

Package
https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/binaries/apache-royale-0.9.7-bin-js-swf.zip
Binary kit signatures match: y
NOTICE is ok: y
LICENSE is ok: y
No unapproved licenses or archives in binary package: y
No unapproved binaries in binary package: y

Encountered one issue with TourDeJewel not building (saw compiler hang)
because copy-themes artifacts where not expressed as release version in the
pom - switching to 0.9.7 instead of 0.9.7-SNAPSHOT fixes this.
Will create a post-release note for that, with instructions for users who
want to build TdJ with maven.



On Sun, May 10, 2020 at 11:44 AM Carlos Rovira <[email protected]>
wrote:

> approve:
>
>
> +1 (Binding)
>
>
> Package
>
> https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/apache-royale-0.9.7-src.tar.gz
>
> Java 1.8
>
> OS: Mac OS X x86_64 10.15.4
>
> Source kit signatures match: y
>
> Source kit builds: y
>
> README is ok: y
>
> RELEASE_NOTES is ok: y
>
> NOTICE is ok: y
>
> LICENSE is ok: y
>
> No unapproved licenses or archives: y
>
> No unapproved binaries: y
>
>
> Package
>
> https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/binaries/apache-royale-0.9.7-bin-js-swf.tar.gz
>
> Binary kit signatures match: y
>
> NOTICE is ok: y
>
> LICENSE is ok: y
>
> No unapproved licenses or archives in binary package: y
>
> No unapproved binaries in binary package: y
>
>
>
>
> main:
>
>
> BUILD SUCCESSFUL
>
>
> El sáb., 9 may. 2020 a las 8:12, Alex Harui (<[email protected]>)
> escribió:
>
> > +1
> > Package
> >
> https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/apache-royale-0.9.7-src.tar.gz
> > Java 1.8
> > OS: Mac OS X x86_64 10.15.3
> > Source kit signatures match: y
> > Source kit builds: y
> > README is ok: y
> > RELEASE_NOTES is ok: y
> > NOTICE is ok: y
> > LICENSE is ok: y
> > No unapproved licenses or archives: y
> > No unapproved binaries: y
> >
> > Package
> >
> https://dist.apache.org/repos/dist/dev/royale/0.9.7/rc5/binaries/apache-royale-0.9.7-bin-js-swf.tar.gz
> > Binary kit signatures match: y
> > NOTICE is ok: y
> > LICENSE is ok: y
> > No unapproved licenses or archives in binary package: y
> > No unapproved binaries in binary package: y
> >
> > On 5/8/20, 2:47 PM, "Josh Tynjala" <[email protected]> wrote:
> >
> >     +1
> >     Package
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fapache-royale-0.9.7-src.zip&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622746320&amp;sdata=YhVkd5RF6uepjp%2FpUOlV91dK1WuNOljN8CD7bMozIME%3D&amp;reserved=0
> >     Java 1.8
> >     OS: Windows 10 amd64 10.0
> >     Source kit signatures match: y
> >     Source kit builds: y
> >     README is ok: y
> >     RELEASE_NOTES is ok: y
> >     NOTICE is ok: y
> >     LICENSE is ok: y
> >     No unapproved licenses or archives: y
> >     No unapproved binaries: y
> >
> >     Package
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js-swf.zip&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622746320&amp;sdata=cuj907UbAEmHubXsi4PtWMR1%2Bj30U%2BiWA584qowNr8Y%3D&amp;reserved=0
> >     Binary kit signatures match: y
> >     NOTICE is ok: y
> >     LICENSE is ok: y
> >     No unapproved licenses or archives in binary package: y
> >     No unapproved binaries in binary package: y
> >
> >     ------
> >
> >     Successfully completed ApproveRoyale.xml twice. Once with
> > -Duse-flash=true
> >     and once without.
> >     Successfully compiled several Royale projects using the binary
> > distribution.
> >     All automated tests for vscode-as3mxml passed using the 0.9.7
> compiler
> > as
> >     the code intelligence provider.
> >
> >     --
> >     Josh Tynjala
> >     Bowler Hat LLC <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622746320&amp;sdata=4dQ8OKV%2BGQNZTgYVfW8GY4aJIoclszovRG6jK0lyW9w%3D&amp;reserved=0
> > >
> >
> >
> >     On Fri, May 8, 2020 at 4:28 AM <[email protected]> wrote:
> >
> >     > Hi,
> >     > This is the vote for the 0.9.7 release of Apache Royale.  The
> release
> >     > candidate can be found here;
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2F&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622746320&amp;sdata=tPZJEMT%2FumESCGQQv1uoIBb8VdxFsD9qjdShODpK0Cc%3D&amp;reserved=0
> >     >
> >     > Before voting please review the section,'What are the ASF
> > requirements on
> >     > approving a release?', at:
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Fdev%2Frelease.html%23approving-a-release&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=%2FW4FYVwkYfhq%2BgOHDc%2F4wI2GOKw4KoWq2lCcqWnoRgA%3D&amp;reserved=0
> >     >
> >     > At a minimum you would be expected to check that:
> >     > - SHA and signed packages are correct
> >     > - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine
> >     > - That the build script completes successfully
> >     > - That you can compile and crosscompile a simple example using the
> > SDK.
> >     >
> >     > The KEYS file is at
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Froyale%2FKEYS&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=tS%2F%2FSTsTUsb17zqXenT%2BWBMd0swVUwq9wY3FxQh06N8%3D&amp;reserved=0
> >     >
> >     > The source package is a combination of the 3 main Royale repos.
> >     >
> >     > To use the binary package, unzip it into a folder. The -js package
> is
> >     > ready-to-use in an IDE or command-line. If you need SWF output, use
> > the
> >     > -js-swf package and use Apache Ant to run the InstallAdobeSDKs
> > script via:
> >     >     ant -f InstallAdobeSDKs.xml
> >     >
> >     > You may also get the binarypackages via NPM. The -js package can be
> >     > installed via:
> >     > npm install
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js.tar.gz&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=BQCossitPeHLyCMBicQryV9oF%2Blf8M%2B7Cq91hkrM0OA%3D&amp;reserved=0
> >     >
> >     > The full package with SWF support can be installed via:
> >     >
> >     > npm install
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js-swf.tar.gz&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=esIuxw0KYlwINJsJgCJKARB43IZMAgOFX6w5hgIXRXs%3D&amp;reserved=0
> >     >
> >     > Maven artifacts are staged here:
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapacheroyale-1077&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=hmkOL9xcDMjG%2BeGqz66JxoksSeltASJyTaxy4MoQ6pk%3D&amp;reserved=0
> >     >
> >     > Please vote to approve this release:
> >     > +1 Approve the release
> >     > -1 Disapprove the release (please provide specific comments to why)
> >     >
> >     > This vote will be open for 72 hours or until a result can be
> called.
> >     >
> >     > The vote passes if there is:
> >     > - At least 3 +1 votes from the PMC
> >     > - More positive votes than negative votes
> >     >
> >     > Remember that this is a 'beta-quality' release so expect there will
> > be
> >     > many bugs found. IMO the goal is not to try to find and fix bugs in
> > the RC,
> >     > but to make sure we have the packaging right, and enough
> > functionality that
> >     > folks will have some success trying to use it.  People who are not
> > in PMC
> >     > are also encouraged to test out the release and vote, although
> their
> > votes
> >     > will not be binding, they can influence how the PMC votes.
> >     >
> >     > When voting please indicate what OS, IDE, Flash Player version and
> > AIR
> >     > version you tested with.
> >     >
> >     > For your convenience, there is an ant script that automates the
> > common
> >     > steps to validate a release.  Instead of individually downloading
> the
> >     > package and signature files, unzipping, etc, you can instead:
> >     > 1) create an empty folder,
> >     > 2) download into that folder this file:
> >     >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2FApproveRoyale.xml&amp;data=02%7C01%7Caharui%40adobe.com%7Cbe66ca620ee74ee1270408d7f3996eb9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637245712622756311&amp;sdata=uOg2QpsCubo8vi8hmxjf8uJTMjBTwFnuiEDA2aZPSU8%3D&amp;reserved=0
> >     > 3) run the script:
> >     >    ant -e -f ApproveRoyale.xml -Drelease.version=0.9.7 -Drc=5
> >     >    If you want to test SWF support during the approval, use:
> >     >    ant -e -f ApproveRoyale.xml -Drelease.version=0.9.7 -Drc=5
> >     > -Duse-flash=true
> >     >
> >     > You are not required to use this script, and more testing of the
> > packages
> >     > and build results are always encouraged.
> >     >
> >     > Please put all discussion about this release in the DISCUSSION
> > thread not
> >     > this VOTE thread.
> >     >
> >     > Thanks,
> >     > Yishay Weiss
> >
> >
> >
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>

Reply via email to