Please use [RESULT] tag in the subject and separate total binding votes and put non-binding votes on a different line.
Thanks, -Alex On 5/13/20, 12:22 AM, "Yishay Weiss" <[email protected]> wrote: Vote passes with FIVE +1 ONE +0 and ONE -1. Thanks to all those who took the time to review this release. It should make the next one even better. From: Harbs<mailto:[email protected]> Sent: Tuesday, May 12, 2020 11:40 PM To: Apache Royale Development<mailto:[email protected]> Subject: Re: [VOTE] Release Apache Royale 0.9.7 +1 Package https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fapache-royale-0.9.7-src.tar.gz&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499341903&sdata=eriysK%2FfYNS8v%2Bzd1tCb%2BohPjjR0MxdTV78FaJMrBTc%3D&reserved=0 Java 1.8 OS: Mac OS X x86_64 10.14.6 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archives: y No unapproved binaries: y Package https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js-swf.tar.gz&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499341903&sdata=qYRNA39jPDjV2RLiFQsy%2B%2BOS5dI1WuhS59FiN8chFbw%3D&reserved=0 Binary kit signatures match: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archives in binary package: y No unapproved binaries in binary package: y The release is not perfect, but it’s a definite improvement and long overdue. I’m voting +1 to get the release out, and we should follow up with the issues that were discovered before the next release. More notes: * I was able to use the release to correctly build a complex app. * There are issues with URLs including http instead of https and references to royale.codeoscopic.com <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Froyale.codeoscopic.com%2F&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=pty%2BLiG7nHmmnu79MFAqJ3FdxmJJEHedjHO91iXi6fs%3D&reserved=0>. I fixed this in the develop branch and I don’t think it’s significant enough to delay the release. * I fixed the small typo that Chris mention in the RELEASE notes in develop as well. * We should use an apache email address for the signature for the next release (should be me), but I did not see anywhere that it’s a requirement — just that there’s a valid signature. * I’ll have to pay attention to SNAPSHOT references when I do the next release. I’m going to need guidance on the best way to handle that. * I’m not sure what Chris’ issues were with references in the various meta files. I’d like to follow up on that before the next release. * I didn’t see an issue with RAT. Not sure what that was about. * The failure of ant clean is normal when clean is run twice. * Carlos: I think you added OpenSans. Can you add the reference to the NOTICE file in develop? > > Am 08.05.20, 13:28 schrieb "[email protected]" <[email protected]>: > > Hi, > This is the vote for the 0.9.7 release of Apache Royale. The release candidate can be found here; > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2F&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=wDhf8b2LdDd9TnW8CDuXzDBG1ZP6xkDCUo%2F%2FbqmMn44%3D&reserved=0 > > Before voting please review the section,'What are the ASF requirements on approving a release?', at: > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Fdev%2Frelease.html%23approving-a-release&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=rQundb9FSLlKjx0tzt7OwBsKyidu4Z1nOLFlGYbWzg0%3D&reserved=0 > > At a minimum you would be expected to check that: > - SHA and signed packages are correct > - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine > - That the build script completes successfully > - That you can compile and crosscompile a simple example using the SDK. > > The KEYS file is at https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Froyale%2FKEYS&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=l2nBhO0uw9vnSAxIXu%2FGXK3h9xG0ocmUUO5Q%2BBUt2lI%3D&reserved=0 > > The source package is a combination of the 3 main Royale repos. > > To use the binary package, unzip it into a folder. The -js package is ready-to-use in an IDE or command-line. If you need SWF output, use the > -js-swf package and use Apache Ant to run the InstallAdobeSDKs script via: > ant -f InstallAdobeSDKs.xml > > You may also get the binarypackages via NPM. The -js package can be installed via: > npm install https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js.tar.gz&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=npcpezRiIRwlrx0tdXFV9JhXeYfIq3jyYhsqV8kffwk%3D&reserved=0 > > The full package with SWF support can be installed via: > > npm install https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2Fbinaries%2Fapache-royale-0.9.7-bin-js-swf.tar.gz&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=zhf%2Btjp01HvVs%2FPeABNtCPwCwlQFb43Rw9nzpZLqi%2FI%3D&reserved=0 > > Maven artifacts are staged here: > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapacheroyale-1077&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=%2BhqWJWkjjobZu2tHTywIXWqomg%2BX4h3yGHQcTP6Nty0%3D&reserved=0 > > Please vote to approve this release: > +1 Approve the release > -1 Disapprove the release (please provide specific comments to why) > > This vote will be open for 72 hours or until a result can be called. > > The vote passes if there is: > - At least 3 +1 votes from the PMC > - More positive votes than negative votes > > Remember that this is a 'beta-quality' release so expect there will be many bugs found. IMO the goal is not to try to find and fix bugs in the RC, but to make sure we have the packaging right, and enough functionality that folks will have some success trying to use it. People who are not in PMC are also encouraged to test out the release and vote, although their votes will not be binding, they can influence how the PMC votes. > > When voting please indicate what OS, IDE, Flash Player version and AIR version you tested with. > > For your convenience, there is an ant script that automates the common steps to validate a release. Instead of individually downloading the package and signature files, unzipping, etc, you can instead: > 1) create an empty folder, > 2) download into that folder this file: > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Froyale%2F0.9.7%2Frc5%2FApproveRoyale.xml&data=02%7C01%7Caharui%40adobe.com%7C61f9e48b7d2547d21e0708d7f70e6461%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637249513499351898&sdata=CFzd3qHnLF3%2FU4Fic2iSZAYVw3K27uhC2VPta8LaK8c%3D&reserved=0 > 3) run the script: > ant -e -f ApproveRoyale.xml -Drelease.version=0.9.7 -Drc=5 > If you want to test SWF support during the approval, use: > ant -e -f ApproveRoyale.xml -Drelease.version=0.9.7 -Drc=5 -Duse-flash=true > > You are not required to use this script, and more testing of the packages and build results are always encouraged. > > Please put all discussion about this release in the DISCUSSION thread not this VOTE thread. > > Thanks, > Yishay Weiss >
