[
https://issues.apache.org/jira/browse/S2GRAPH-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704514#comment-15704514
]
ASF GitHub Bot commented on S2GRAPH-130:
----------------------------------------
Github user daewon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/100#discussion_r89953420
--- Diff: s2core/src/main/scala/org/apache/s2graph/core/Edge.scala ---
@@ -381,6 +645,23 @@ object Edge {
propsWithoutLastDeletedAt.forall { case (_, v) => v.ts <=
lastDeletedAt }
}
+ def allPropsDeleted(props: Props): Boolean =
+ if (!props.containsKey(LabelMeta.lastDeletedAt.name)) false
+ else {
+ val lastDeletedAt = props.get(LabelMeta.lastDeletedAt.name).ts
+ props.remove(LabelMeta.lastDeletedAt.name)
+// val propsWithoutLastDeletedAt = props
+//
+// propsWithoutLastDeletedAt.forall { case (_, v) => v.ts <=
lastDeletedAt }
+ var ret = true
+ val iter = props.entrySet().iterator()
+ while (iter.hasNext) {
+ val e = iter.next()
+ if (e.getValue.ts > lastDeletedAt) ret = false
--- End diff --
The while statement does not terminate the loop even if the condition
'(e.getValue.ts> lastDeletedAt)' is satisfied.
> Edge.propsWithTs data type should be changed into mutable to support setter
> interface exist in tp3.
> ---------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-130
> URL: https://issues.apache.org/jira/browse/S2GRAPH-130
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
>
> Change {{Edge.propsWithTs}} data type to java.util.Map[should be changed into
> mutable to support setter interface exist in tp3.
> This issue intentionally left implementation for interface in tp3, but rather
> focus changing S2Graph's core {{Edge/Vertex/Graph}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
