[
https://issues.apache.org/jira/browse/S2GRAPH-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705063#comment-15705063
]
ASF GitHub Bot commented on S2GRAPH-130:
----------------------------------------
Github user SteamShon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/100
@daewon actually adding `equals`, `hashCode`, `toString` for
Edge/Vertex/S2Property/S2VertexProperty class reside on different PR #101.
@HyunsungJo I will remove commented out codes. About EdgeTest,
IndexEdgeTest, I think #101 has necessary code for them(just the methods
@daewon mentioned above).
Sorry for splitting up same logical commit into different PR(I found out
this while I was working on #101 ^^;;). Maybe I will fix up removed test
cases(EdgeTest, IndexEdgeTest, etc) on #101.
> Edge.propsWithTs data type should be changed into mutable to support setter
> interface exist in tp3.
> ---------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-130
> URL: https://issues.apache.org/jira/browse/S2GRAPH-130
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
>
> Change {{Edge.propsWithTs}} data type to java.util.Map[should be changed into
> mutable to support setter interface exist in tp3.
> This issue intentionally left implementation for interface in tp3, but rather
> focus changing S2Graph's core {{Edge/Vertex/Graph}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
