[
https://issues.apache.org/jira/browse/S2GRAPH-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704530#comment-15704530
]
ASF GitHub Bot commented on S2GRAPH-130:
----------------------------------------
Github user daewon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/100
When you add a field, you should not forget to modify the function such as
'equals', 'hashcode', etc.
It would be nice if a test for this would be added.
I'm a little sorry to lose the advantage of the 'case class' provided by
scala, but I think there is more to be gained when you support 'tinkerpop' as a
native.
+1
> Edge.propsWithTs data type should be changed into mutable to support setter
> interface exist in tp3.
> ---------------------------------------------------------------------------------------------------
>
> Key: S2GRAPH-130
> URL: https://issues.apache.org/jira/browse/S2GRAPH-130
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
>
> Change {{Edge.propsWithTs}} data type to java.util.Map[should be changed into
> mutable to support setter interface exist in tp3.
> This issue intentionally left implementation for interface in tp3, but rather
> focus changing S2Graph's core {{Edge/Vertex/Graph}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
