[ https://issues.apache.org/jira/browse/S2GRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704602#comment-15704602 ]
ASF GitHub Bot commented on S2GRAPH-131: ---------------------------------------- Github user daewon commented on the issue: https://github.com/apache/incubator-s2graph/pull/101 I have verified that the existing test cases work well, and the code seems to be fine. It seems to be able to make the part that returns `util.Iterator` somewhat efficient, and this part will be created as a separate issue. P.s: 'thinkerpop' looks like a very interesting project. But I still do not have enough knowledge of 'tinkerpop' to review the code. +1 > Add actual implementation on interfaces from TinkerPop3 structure package. > -------------------------------------------------------------------------- > > Key: S2GRAPH-131 > URL: https://issues.apache.org/jira/browse/S2GRAPH-131 > Project: S2Graph > Issue Type: Sub-task > Affects Versions: 0.2.0 > Reporter: DOYUNG YOON > Assignee: DOYUNG YOON > Fix For: 0.2.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > Based on changes from S2GRAPH-129, S2GRAPH-130, it's easy to implement > tinkerpop3's structure interfaces directly. > This issue is about change our previous core entity {{Edge/Vertex/Graph}} > into {{S2Edge/S2Vertex/S2Graph}}. > I suggest to focus on naive implementation first on this issue, then improve > tp3 integration while we discuss. > Of course test cases, documentations should be followed up. > I suggest to create more subtask under S2GRAPH-72, so we can track them > easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)