[
https://issues.apache.org/jira/browse/S2GRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705202#comment-15705202
]
ASF GitHub Bot commented on S2GRAPH-131:
----------------------------------------
Github user SteamShon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/101
@HyunsungJo there is actually no test cases for tinkerpop parts. I only
added the very basic. I think the right way to test if we are implementing tp3
correctly running gremlin test suite. To run gremlin test suite, I guess we
need to decide which features we are going to provide(I briefly mentioned on
https://lists.apache.org/thread.html/da3434f2338f8605909c40758c2c4ef35c1a0bee27eba6951316a3fb@%3Cdev.s2graph.apache.org%3E)
since test suite decide which test to run based on this feature on Graph
class(Correct me if I am wrong). So in this pr, I more focused on providing
naive implementation and make sure our existing code does not break. I suggest
to separate validation on tinkerpop interface through gremlin test suite to
other issue.
> Add actual implementation on interfaces from TinkerPop3 structure package.
> --------------------------------------------------------------------------
>
> Key: S2GRAPH-131
> URL: https://issues.apache.org/jira/browse/S2GRAPH-131
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Based on changes from S2GRAPH-129, S2GRAPH-130, it's easy to implement
> tinkerpop3's structure interfaces directly.
> This issue is about change our previous core entity {{Edge/Vertex/Graph}}
> into {{S2Edge/S2Vertex/S2Graph}}.
> I suggest to focus on naive implementation first on this issue, then improve
> tp3 integration while we discuss.
> Of course test cases, documentations should be followed up.
> I suggest to create more subtask under S2GRAPH-72, so we can track them
> easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
