[
https://issues.apache.org/jira/browse/S2GRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705222#comment-15705222
]
ASF GitHub Bot commented on S2GRAPH-131:
----------------------------------------
Github user SteamShon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/101
@daewon
```It seems to be able to make the part that returns util.Iterator somewhat
efficient, and this part will be created as a separate issue.```
Correct me if I am wrong, but I think you are suggesting providing iterator
`util.Iterator[Edge]` on `StepResult`.
Since there is only one way to iterate edges by iterate through
`Seq[EdgeWithScore]`, we had to run map on this sequence of `EdgeWithScore` to
get util.Iterator[Edge], which tinkerpop interface expect.
I think it is very good idea to provide iterator `util.Iterator[Edge]` in
`StepResult` so we can just simply return it when it is necessary rather than
create new sequence of Edge. Can you please create a separate Jira issue for
this?
> Add actual implementation on interfaces from TinkerPop3 structure package.
> --------------------------------------------------------------------------
>
> Key: S2GRAPH-131
> URL: https://issues.apache.org/jira/browse/S2GRAPH-131
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Based on changes from S2GRAPH-129, S2GRAPH-130, it's easy to implement
> tinkerpop3's structure interfaces directly.
> This issue is about change our previous core entity {{Edge/Vertex/Graph}}
> into {{S2Edge/S2Vertex/S2Graph}}.
> I suggest to focus on naive implementation first on this issue, then improve
> tp3 integration while we discuss.
> Of course test cases, documentations should be followed up.
> I suggest to create more subtask under S2GRAPH-72, so we can track them
> easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
