----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156276 -----------------------------------------------------------
Fix it, then Ship it! lgtm! docs/learn/documentation/versioned/container/checkpointing.md (line 125) <https://reviews.apache.org/r/53826/#comment226471> "...some use-cases when we may need to inform the System about..." > Instead of using System, you can say Consumer. This notification mechanism provides a way for Samza to interact with the SystemConsumer docs/learn/documentation/versioned/container/checkpointing.md (line 126) <https://reviews.apache.org/r/53826/#comment226470> Typo : "checkpointg" docs/learn/documentation/versioned/container/checkpointing.md (line 130) <https://reviews.apache.org/r/53826/#comment226472> Should we mention this since I don't know of a real world use-case that does this? :P Not a big deal.. Just wondering.. if you think it is useful, we can leave it here docs/learn/documentation/versioned/container/checkpointing.md (line 138) <https://reviews.apache.org/r/53826/#comment226473> suggestion: Highlight "not" in "not atomic" -> **not** atomic - Navina Ramesh On Nov. 16, 2016, 11:28 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53826/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 11:28 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1046 > https://issues.apache.org/jira/browse/SAMZA-1046 > > > Repository: samza > > > Description > ------- > > added user documentation for Checkpoint callbacks > > > Diffs > ----- > > docs/learn/documentation/versioned/container/checkpointing.md > 6f8c6d694be92f973af456ddd518d70540abe5c3 > > Diff: https://reviews.apache.org/r/53826/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
