----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156607 -----------------------------------------------------------
Ship it! Looks good. Minor comments. docs/learn/documentation/versioned/container/checkpointing.md (line 126) <https://reviews.apache.org/r/53826/#comment226779> Can be moved to previous line. docs/learn/documentation/versioned/container/checkpointing.md (line 129) <https://reviews.apache.org/r/53826/#comment226780> What does the "push system" mean? Maybe clarify/remove? docs/learn/documentation/versioned/container/checkpointing.md (line 138) <https://reviews.apache.org/r/53826/#comment226781> Multiple "and"s in the sentence. Maybe "... for a task. These are the ..."? - Prateek Maheshwari On Nov. 18, 2016, 4:52 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53826/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 4:52 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1046 > https://issues.apache.org/jira/browse/SAMZA-1046 > > > Repository: samza > > > Description > ------- > > added user documentation for Checkpoint callbacks > > > Diffs > ----- > > docs/learn/documentation/versioned/container/checkpointing.md > 6f8c6d694be92f973af456ddd518d70540abe5c3 > > Diff: https://reviews.apache.org/r/53826/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
