> On Nov. 18, 2016, 2:36 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/container/checkpointing.md, line 130 > > <https://reviews.apache.org/r/53826/diff/1/?file=1565544#file1565544line130> > > > > Should we mention this since I don't know of a real world use-case that > > does this? :P Not a big deal.. Just wondering.. if you think it is useful, > > we can leave it here
Kafka may use it in the future, so I'd rather leave it in. > On Nov. 18, 2016, 2:36 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/container/checkpointing.md, line 138 > > <https://reviews.apache.org/r/53826/diff/1/?file=1565544#file1565544line138> > > > > suggestion: Highlight "not" in "not atomic" -> **not** atomic good suggestion. done. - Boris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156276 ----------------------------------------------------------- On Nov. 16, 2016, 11:28 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53826/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 11:28 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1046 > https://issues.apache.org/jira/browse/SAMZA-1046 > > > Repository: samza > > > Description > ------- > > added user documentation for Checkpoint callbacks > > > Diffs > ----- > > docs/learn/documentation/versioned/container/checkpointing.md > 6f8c6d694be92f973af456ddd518d70540abe5c3 > > Diff: https://reviews.apache.org/r/53826/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
