-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28035/
-----------------------------------------------------------
(Updated Nov. 15, 2014, 12:24 a.m.)
Review request for samza.
Changes
-------
made the log4jConfig java-pure
made the streamName(topic) configurable from log4j.xml
made the log4jConfig to guess the systemName when it's not specified
added javadocs
added to configration-table.html and logging.md
changed the key to use "samza-container-%id"
changed the default streamName
added logs in activeOptions
Bugs: SAMZA-310
https://issues.apache.org/jira/browse/SAMZA-310
Repository: samza
Description
-------
Added a log4j appender using SystemProducer
Added a log4jConfig class to help get log4j specific config
Unit test code
Diffs (updated)
-----
build.gradle 828bce9
docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4
docs/learn/documentation/versioned/jobs/logging.md 58e56c1
samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java
PRE-CREATION
samza-log4j/src/main/java/org/apache/samza/logging/log4j/SystemProducerAppender.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestSystemProducerAppender.java
PRE-CREATION
Diff: https://reviews.apache.org/r/28035/diff/
Testing
-------
Thanks,
Yan Fang
