-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28035/
-----------------------------------------------------------
(Updated Nov. 24, 2014, 9:16 a.m.)
Review request for samza.
Changes
-------
1. changed to StreamAppender, updated docs accordingly.
2. removed the kafka in unit test, instead, use mock system
3. updated log.info in activeOptions, to make it more meaningful
4. updated getConfig() method to fix the expcetion.
Bugs: SAMZA-310
https://issues.apache.org/jira/browse/SAMZA-310
Repository: samza
Description
-------
Added a log4j appender using SystemProducer
Added a log4jConfig class to help get log4j specific config
Unit test code
Diffs (updated)
-----
build.gradle 828bce9
docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4
docs/learn/documentation/versioned/jobs/logging.md 58e56c1
samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java
PRE-CREATION
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemFactory.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemProducer.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java
PRE-CREATION
Diff: https://reviews.apache.org/r/28035/diff/
Testing
-------
Thanks,
Yan Fang
