----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28035/#review62838 -----------------------------------------------------------
Ship it! Looks good overall. Some minor comments on the RB. samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java <https://reviews.apache.org/r/28035/#comment104970> Maybe use 'static' also for these constants ? samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java <https://reviews.apache.org/r/28035/#comment104971> Maybe also clarify that in addition to missing task.log4j.system, more than 1 systems were found ? samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java <https://reviews.apache.org/r/28035/#comment104975> Any reason why this isn't in the config ? i.e. Why not getSystemFactory (instead of getSystemFactoryAsString) ? - Chinmay Soman On Nov. 24, 2014, 9:16 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28035/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 9:16 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-310 > https://issues.apache.org/jira/browse/SAMZA-310 > > > Repository: samza > > > Description > ------- > > Added a log4j appender using SystemProducer > Added a log4jConfig class to help get log4j specific config > Unit test code > > > Diffs > ----- > > build.gradle 828bce9 > docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4 > docs/learn/documentation/versioned/jobs/logging.md 58e56c1 > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java > PRE-CREATION > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemFactory.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemProducer.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28035/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
