Hi Yoann, I have some comment on your code, but keep in mind that I'm not speaking for the core develoment team, so my comments are merely my personal observations, nothing more.
To the core team, please correct or supplement my comments it they don't make sense. On Wed, 30 Mar 2005 01:04:51 +0200, Le Farfadet Spatial <[EMAIL PROTECTED]> wrote: ... > The last code I have send on issue 25478 do not need many things > before > being an UNO component, in fact I have just to do some minor > improvements before working on the interface but, well, I have not take > the time do to this... If I understand it correctly, this code of yours is aiming to replace the existing regression functionality with better performance, am I correct on this assertion? > Please, take a look on the code I let on issue 25478 (the code I have > send January 4, 2005) and tell me what you do think of it. I have just spent some time running the code, and it seems fast. Unfortunately, I can't comment on the internal algorithm of your code since I'm not familiar with the algorithms used, :P but I think it would make sense to quantify the performance of your code in some way so that it can be compared against the existing code with actual numbers, especially if it aims to replace the existing code. Also, it would probably help the person who will eventually review your code if you could make your code adhere to the coding guidelines that the core team developers and contributors follow. The guidelines doc can be found... geez where is it? I have a copy on my machine, but it can be downloaded somewhere within the OO.o website. It's just a matter of finding it..... *me looks around* Oh I found it. :-) http://tools.openoffice.org/CodingGuidelines.html You don't necessarily need to read the whole thing, but just the part that talks about how variables are named and such. Also this page that Michael Meeks just wrote will help: http://go-oo.org/patches.html Thanks for your work! Kohei --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
