Hello every body out there !
Kohei Yoshida wrote :
I have some comment on your code, but keep in mind that I'm not speaking for the core develoment team, so my comments are merely my personal observations, nothing more.
I am happy to receive any observations. I thank you.
If I understand it correctly, this code of yours is aiming to replace the existing regression functionality with better performance, am I correct on this assertion?
In fact, my purpose is to give much more functionalities, including, for instance, non linear fitting -- which are not implemented nowadays. Anyway, I want to give the fastest code I can, and the more precise too.
Unfortunately, I can't comment on the internal algorithm of your code since I'm not familiar with the algorithms used, :P but I think it would make sense to quantify the performance of your code in some way so that it can be compared against the existing code with actual numbers, especially if it aims to replace the existing code.
Yes, I have planed to do this and... I have not make the benchmarks...
Also, it would probably help the person who will eventually review your code if you could make your code adhere to the coding guidelines that the core team developers and contributors follow. The guidelines doc can be found... geez where is it? I have a copy on my machine, but it can be downloaded somewhere within the OO.o website. It's just a matter of finding it..... *me looks around*
Oh I found it. :-)
http://tools.openoffice.org/CodingGuidelines.html
You don't necessarily need to read the whole thing, but just the part that talks about how variables are named and such. Also this page that Michael Meeks just wrote will help:
http://go-oo.org/patches.html
Thank you. I will take a better look on it.
Best regards.
Yoann LE BARS,
alias Le Farfadet Spatial--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
