On Tue, 2008-12-09 at 18:29 +0100, Niklas Nebel wrote: > On 12/08/08 21:20, Kohei Yoshida wrote: > > On Mon, 2008-12-08 at 20:43 +0100, Niklas Nebel wrote: > >> Again, modularization. We want to separate the Excel filter from the > >> "sc" module, and opcode mapping is part of it. > > > > But VBA is not part of the filter, and we need that for VBA. The filter > > is merely re-using it. > > > > There is a fine line between modularization and reusability. > > To share something between the filter and VBA, it doesn't have to become > part of the Calc core.
On the contrary, I believe this opcode map does belong in the core. Doing it any other way, especially a duplication of opcode in various places, is a kludge. While it's important to separate out things from the core, there are still things that *do* belong in the core. > This is now the second change surfacing from ooxml02 which runs contrary > to the separation of filter and core. Once again, VBA is not a filter, and I don't see how that would contradicts the separation of filter and core. > I hope this doesn't become a trend. What trend? The change I made was what I believed to be the best move given the existing code structure and what needed to be done. If you have any imaginary trend that you think exists, it's not part of it, whatever that trend may be. Kohei --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
