lewismc commented on a change in pull request #6: SDAP-35 (completed the
configuration change)
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172921684
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngine.java
##########
@@ -99,11 +99,11 @@ public void preprocess() {
ArrayList<String> inputList = (ArrayList<String>)
getFileList(props.getProperty(MudrodConstants.DATA_DIR));
- for (String anInputList : inputList) {
- timeSuffix = anInputList;
+ for (int i = 0; i < inputList.size(); i++) {
Review comment:
This propose change is actually worse for execution. List comprehension in
Java is more performant the way it is. Your proposal slows it down, please
revert your change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
