lewismc commented on a change in pull request #6: SDAP-35 (completed the 
configuration change)
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172928676
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/recommendation/pre/ImportMetadata.java
 ##########
 @@ -65,8 +64,8 @@ public void addMetadataMapping() {
     String mappingJson = "{\r\n   \"dynamic_templates\": " + "[\r\n      " + 
"{\r\n         \"strings\": " + "{\r\n            \"match_mapping_type\": 
\"string\","
         + "\r\n            \"mapping\": {\r\n               \"type\": 
\"string\"," + "\r\n               \"analyzer\": \"csv\"\r\n            }" + 
"\r\n         }\r\n      }\r\n   ]\r\n}";
 
-    
es.getClient().admin().indices().preparePutMapping(props.getProperty(MudrodConstants.ES_INDEX_NAME)).setType(props.getProperty("recom_metadataType")).setSource(mappingJson).execute().actionGet();
-
+    
es.getClient().admin().indices().preparePutMapping(props.getProperty(MudrodConstants.ES_INDEX_NAME))
+    
.setType(MudrodConstants.RECOM_METADATA_TYPE).setSource(mappingJson).execute().actionGet();
 
 Review comment:
   Why is this now separated over a line break?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to