lewismc commented on a change in pull request #6: SDAP-35 (completed the configuration change) URL: https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172924046
########## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodConstants.java ########## @@ -13,63 +13,73 @@ */ package org.apache.sdap.mudrod.main; -import org.apache.sdap.mudrod.ontology.Ontology; - /** * Class contains static constant keys and values relating to Mudrod * configuration properties. Property values are read from <a href= * "https://github.com/mudrod/mudrod/blob/master/core/src/main/resources/config.xml";>config.xml</a> */ public interface MudrodConstants { - public static final String CLEANUP_TYPE_PREFIX = "Cleanup_type_prefix"; - - public static final String CLICK_STREAM_LINKAGE_TYPE = "clickStreamLinkageType"; + public static final String CLEANUP_TYPE = "cleanupLog"; - public static final String CLICK_STREAM_MATRIX_TYPE = "clickStreamMatrixType"; + public static final String CLICK_STREAM_LINKAGE_TYPE = "clickStreamLinkage"; - public static final String CLICKSTREAM_SVD_DIM = "clickstreamSVDDimension"; + public static final String CLICK_STREAM_MATRIX_TYPE = "clickStreamMatrix"; Review comment: Should be ```click.stream.matrix``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
