lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD 
configuration
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173492972
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/metadata/pre/ApiHarvester.java
 ##########
 @@ -57,7 +57,8 @@ public Object execute() {
     //remove old metadata from ES
     es.deleteType(props.getProperty(MudrodConstants.ES_INDEX_NAME), 
props.getProperty(MudrodConstants.RAW_METADATA_TYPE));
     //harvest new metadata using PO.DAAC web services
-    harvestMetadatafromWeb();
+    if(props.getProperty(MudrodConstants.METADATA_DOWNLOAD).equals("1")) 
 
 Review comment:
   I have a feeling that the string should be on the left hand side of the 
logic as per 
   ```
   if("1".equals(props.getProperty(MudrodConstants.METADATA_DOWNLOAD)))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to