lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173493250
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/metadata/structure/MetadataExtractor.java
##########
@@ -67,31 +67,15 @@ public MetadataExtractor() {
* @param type metadata type name
* @return metadata list
*/
- protected List<PODAACMetadata> loadMetadataFromES(ESDriver es, String index,
String type) {
+ protected List<Metadata> loadMetadataFromES(ESDriver es, String index,
String type) {
- List<PODAACMetadata> metadatas = new ArrayList<PODAACMetadata>();
+ List<Metadata> metadatas = new ArrayList<Metadata>();
Review comment:
There is no need to add type safety to the right hand side of the
assignment/ Please just use the diamond operator ```<>``` e.g. remove
```Metadata```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
