lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173492545
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
##########
@@ -138,48 +138,37 @@ private InputStream locateConfig() {
LOG.info("Loaded config file from " + configFile.getAbsolutePath());
return configStream;
} catch (IOException e) {
- LOG.info("File specified by environment variable " +
MudrodConstants.MUDROD_CONFIG + "=\'" + configLocation + "\' could not be
loaded. " + e.getMessage());
+ LOG.info("File specified by environment variable " +
MudrodConstants.MUDROD_CONFIG + "=\'" + configLocation + "\' could not be
loaded. Default configuration will be used." + e.getMessage());
Review comment:
Please change to and use [paramaterized
logging](https://www.slf4j.org/faq.html#logging_performance) for all future
logging. The implementation should be
```
LOG.info("File specified by environment variable {} = '{}' could not be
loaded. Default configuration will be used.", MudrodConstants.MUDROD_CONFIG,
configLocation, e.getMessage());
```
Please use paramaterized logging whenever possible, it is a much more
efficient implementation than string concatenation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
