quintinali commented on a change in pull request #33: SDAP-70 Link events with
dataset collections
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/33#discussion_r207371953
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
##########
@@ -235,7 +237,7 @@ public void startMetaIngest() {
LOG.info("Metadata has been ingested successfully.");
}
- public void startFullIngest() {
+ public void startFullIngest(MudrodEngine me) {
DiscoveryEngineAbstract wd = new WeblogDiscoveryEngine(props, es, spark);
Review comment:
EventIngester has a variable of MudrodEngine type since EventIngester
extends MudrodAbstract class. I don't think you have to change function from
startFullIngest() to startFullIngest(MudrodEngine me).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
