quintinali commented on a change in pull request #33: SDAP-70 Link events with
dataset collections
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/33#discussion_r207372783
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
##########
@@ -247,6 +249,9 @@ public void startFullIngest() {
DiscoveryEngineAbstract recom = new RecommendEngine(props, es, spark);
recom.preprocess();
recom.process();
+
+ EventIngester eonet = new EventIngester(props, es, spark);
+ eonet.ingestAllEonetEvents(me);
Review comment:
I suggest removing input parameters "me" since EventIngester already has a
variable of ESDriver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
