quintinali commented on a change in pull request #33: SDAP-70 Link events with
dataset collections
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/33#discussion_r207373467
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
##########
@@ -273,6 +278,13 @@ public void startProcessing() {
recom.process();
}
+ private void startFullEonetIngest(MudrodEngine me) {
+ LOG.info("Starting full EONET ingest.");
+ EventIngester eonet = new EventIngester(props, es, spark);
+ eonet.ingestAllEonetEvents(me);
Review comment:
I suggest removing input parameters "me" since EventIngester already has a
variable of MudrodEngine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
