Imbruced commented on code in PR #647:
URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r917268766
##########
common/src/main/java/org/apache/sedona/Functions.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.sedona;
+
+import org.locationtech.jts.geom.Coordinate;
+import org.locationtech.jts.geom.Geometry;
+
+public class Functions {
+ public static double ST_Distance(Geometry left, Geometry right) {
+ return left.distance(right);
+ }
+
+ public static double ST_YMin(Geometry geometry) {
Review Comment:
I like the idea about applying DRY to Sedona in that scenarios, but dont
know if that naming is right in this context, maybe we should keep camel case
here but only in SQL functions where we are forced we can use ST_* like naming
? WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
