Kimahriman commented on code in PR #647:
URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r923549826
##########
common/src/main/java/org/apache/sedona/Functions.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.sedona;
+
+import org.locationtech.jts.geom.Coordinate;
+import org.locationtech.jts.geom.Geometry;
+
+public class Functions {
+ public static double ST_Distance(Geometry left, Geometry right) {
Review Comment:
Good point, it's really a matter of safety vs performance if the engine has
a better way it can handle null checks. For example it would be pretty trivial
to make a Spark codegen wrapper for the functions that only checks for nulls if
the input is actually nullable. Really just depends if you want to be able to
squeeze every last drop of performance out or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
