umartin commented on code in PR #647:
URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r923290517


##########
common/src/main/java/org/apache/sedona/Functions.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.sedona;

Review Comment:
   The package name should probably be org.apache.sedona.common.
   
   It's safer to let each maven module have their own package namespace. For 
instance OSGi runtimes have a strict requirement on that.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to