----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review152076 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 43) <https://reviews.apache.org/r/52675/#comment220786> better to add a space after '//' sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 84) <https://reviews.apache.org/r/52675/#comment220787> shall we print out configFileFullPath here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 91) <https://reviews.apache.org/r/52675/#comment220788> shall we add 'per' in the config names to make them more clear? Like AVG_VIEWS_PER_DATABASE sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 102) <https://reviews.apache.org/r/52675/#comment220798> what's the meaning of managed table? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 119) <https://reviews.apache.org/r/52675/#comment220791> since KEYTAB_LOCATION is hdfs keytab, we'd better add hdfs in the config name. Or we can add another config for the run as user which is hdfs by default sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 136) <https://reviews.apache.org/r/52675/#comment220790> better to log the EXT_TEST_DATA_PATH, since we will overwrite the dir in line137 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 143) <https://reviews.apache.org/r/52675/#comment220792> remove or update the comment? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 145) <https://reviews.apache.org/r/52675/#comment220789> KEYTAB_LOCATION maybe null or empty, we'd better do some checks before using it sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 152) <https://reviews.apache.org/r/52675/#comment220793> do we need to check HS2_SSL_TRUST_STORE and HS2_SSL_TRUST_STORE_PWD is not null or empty here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 178) <https://reviews.apache.org/r/52675/#comment220796> seems all exception is caught and we can remove SQLException here. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 195) <https://reviews.apache.org/r/52675/#comment220795> shall we throw exception instread of return hs2Conn here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 197) <https://reviews.apache.org/r/52675/#comment220794> shall we call statement.close() in finally when there is exception? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 208) <https://reviews.apache.org/r/52675/#comment220797> what is seq? what if NUM_OF_DATABASES_PER_THREAD - seq - 1 == 0? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 243) <https://reviews.apache.org/r/52675/#comment220800> use fileSystem.create(extPath, false) instead? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 255) <https://reviews.apache.org/r/52675/#comment220801> shall we log the exception here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 280) <https://reviews.apache.org/r/52675/#comment220802> use a final member var for column s1 here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 298) <https://reviews.apache.org/r/52675/#comment220803> remove the space between i and '++'? Also in other for loops in the function. - Li Li On Oct. 10, 2016, 6:14 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52675/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 6:14 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1497 > https://issues.apache.org/jira/browse/SENTRY-1497 > > > Repository: sentry > > > Description > ------- > > Specify the scale numbers like databases, tables, views, partitions, columns, > uris, privileges, role, and groups in a config file, the tool can create such > volume of data in Sentry and HMS databases. To speed up test, it can also do > the task parallelly. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > a2512ee3919a3958425f4ab74b178d02e0402315 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh > dcdddeb95a896ca8470d0b994f5460531e34d113 > > Diff: https://reviews.apache.org/r/52675/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
