> On Oct. 12, 2016, 5:10 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java, > > line 33 > > <https://reviews.apache.org/r/52675/diff/3/?file=1530271#file1530271line33> > > > > Why make it non final?
Will add it back. > On Oct. 12, 2016, 5:10 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java, > > line 60 > > <https://reviews.apache.org/r/52675/diff/3/?file=1530271#file1530271line60> > > > > how about just using: val = System.getProperty(hiveVar, new > > Configuration().get(hiveVar)) ? Yeah, will combine the lines. > On Oct. 12, 2016, 5:10 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java, > > line 69 > > <https://reviews.apache.org/r/52675/diff/3/?file=1530271#file1530271line69> > > > > seems it may not be system property, see line 63? Didn't get it here. val = System.getProperty(...,...), so the comment clarifies it as a system property. > On Oct. 12, 2016, 5:10 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java, > > line 42 > > <https://reviews.apache.org/r/52675/diff/3/?file=1530272#file1530272line42> > > > > run -> running ? Will change it to Before run. > On Oct. 12, 2016, 5:10 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/TestTools.java, > > line 68 > > <https://reviews.apache.org/r/52675/diff/3/?file=1530273#file1530273line68> > > > > do we need to add 'else' for all other cases (print help)? Added in the latest patch. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review152274 ----------------------------------------------------------- On Oct. 18, 2016, 10:19 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52675/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 10:19 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1497 > https://issues.apache.org/jira/browse/SENTRY-1497 > > > Repository: sentry > > > Description > ------- > > Specify the scale numbers like databases, tables, views, partitions, columns, > uris, privileges, role, and groups in a config file, the tool can create such > volume of data in Sentry and HMS databases. To speed up test, it can also do > the task parallelly. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > a2512ee3919a3958425f4ab74b178d02e0402315 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > 90713b1aaa688808859e670c8799f8e5be2d6d26 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/TestTools.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh > dcdddeb95a896ca8470d0b994f5460531e34d113 > > Diff: https://reviews.apache.org/r/52675/diff/ > > > Testing > ------- > > Most recent run uses scale configuration. Totaly running time is 725 secs > with 50 threads on a real cluster. > > Objects status: total databases(300); tables(1224), views(503), > partitions(5505), columns(1905); > Privileges status: database privileges(299), table privileges(824), view > privileges(503), partition privileges(204), column privileges(299), uri > privileges(204); roles(1000), groups(500); > failed threads(1), running time(725 secs) > > > Thanks, > > Anne Yu > >
