----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review153203 -----------------------------------------------------------
Thanks for adding this Anne. A few comments. sentry-tests/sentry-tests-hive/pom.xml (line 36) <https://reviews.apache.org/r/52675/#comment222484> Why do we need Hive lib ? sentry-tests/sentry-tests-hive/pom.xml (line 503) <https://reviews.apache.org/r/52675/#comment222486> May be add some details here in a comment on what this profile is for and reason behind configuring it the way it is? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java (line 24) <https://reviews.apache.org/r/52675/#comment222485> Not entirely sure why this commit requires changes in UnmanagedHiveServer? Can we add a comment to the commit message or RB summary? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 52) <https://reviews.apache.org/r/52675/#comment222488> Why copy hive-site? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 60) <https://reviews.apache.org/r/52675/#comment222489> Is the name accurate? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 80) <https://reviews.apache.org/r/52675/#comment222491> Where are these defined? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 93) <https://reviews.apache.org/r/52675/#comment222492> Does it make sense to also track cardinality of joins? Role - group, role - privilege? As most of our for loops and joins will be affected with these numbers. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (line 99) <https://reviews.apache.org/r/52675/#comment222495> Is it better to take a command line argument instead of environmnet variable? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java (lines 130 - 131) <https://reviews.apache.org/r/52675/#comment222506> What these values correspond to? Can we add some description to the class itself on what inputs it expects and how it gets the values and privileges a user needs to run this tool? - Sravya Tirukkovalur On Oct. 18, 2016, 10:19 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52675/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 10:19 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1497 > https://issues.apache.org/jira/browse/SENTRY-1497 > > > Repository: sentry > > > Description > ------- > > Specify the scale numbers like databases, tables, views, partitions, columns, > uris, privileges, role, and groups in a config file, the tool can create such > volume of data in Sentry and HMS databases. To speed up test, it can also do > the task parallelly. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > a2512ee3919a3958425f4ab74b178d02e0402315 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > 90713b1aaa688808859e670c8799f8e5be2d6d26 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/TestTools.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh > dcdddeb95a896ca8470d0b994f5460531e34d113 > > Diff: https://reviews.apache.org/r/52675/diff/ > > > Testing > ------- > > Most recent run uses scale configuration. Totaly running time is 725 secs > with 50 threads on a real cluster. > > Objects status: total databases(300); tables(1224), views(503), > partitions(5505), columns(1905); > Privileges status: database privileges(299), table privileges(824), view > privileges(503), partition privileges(204), column privileges(299), uri > privileges(204); roles(1000), groups(500); > failed threads(1), running time(725 secs) > > > Thanks, > > Anne Yu > >
