> On Oct. 21, 2016, 6:34 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/pom.xml, line 510 > > <https://reviews.apache.org/r/52675/diff/5/?file=1541755#file1541755line510> > > > > Should we use root pom version?
Didn't notice it and I will inherit from root. > On Oct. 21, 2016, 6:34 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java, > > line 112 > > <https://reviews.apache.org/r/52675/diff/5/?file=1541756#file1541756line112> > > > > Why do we need to maunally load the class here? Yeah, will modify it to be more flexible. > On Oct. 21, 2016, 6:34 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml, > > line 94 > > <https://reviews.apache.org/r/52675/diff/5/?file=1541759#file1541759line94> > > > > Can you comment on what are those configure for? For the HiveService's admin group and user. Usually within sentry maven test we use ADMIN1; on a real cluster system it uses hive. So make it configurable. Will add a comment to clarify. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review153475 ----------------------------------------------------------- On Oct. 19, 2016, 6:48 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52675/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 6:48 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1497 > https://issues.apache.org/jira/browse/SENTRY-1497 > > > Repository: sentry > > > Description > ------- > > Specify the scale numbers like databases, tables, views, partitions, columns, > uris, privileges, role, and groups in a config file, the tool can create such > volume of data in Sentry and HMS databases. To speed up test, it can also do > the task parallelly. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > a2512ee3919a3958425f4ab74b178d02e0402315 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > 90713b1aaa688808859e670c8799f8e5be2d6d26 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/TestTools.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh > dcdddeb95a896ca8470d0b994f5460531e34d113 > > Diff: https://reviews.apache.org/r/52675/diff/ > > > Testing > ------- > > Most recent run uses scale configuration. Totaly running time is 725 secs > with 50 threads on a real cluster. > > Objects status: total databases(300); tables(1224), views(503), > partitions(5505), columns(1905); > Privileges status: database privileges(299), table privileges(824), view > privileges(503), partition privileges(204), column privileges(299), uri > privileges(204); roles(1000), groups(500); > failed threads(1), running time(725 secs) > > > Thanks, > > Anne Yu > >
