----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ -----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector. Repository: sentry Description ------- SENTRY-1548 Setting GrantOption to UNSET upsets Sentry I have made changes assuming that grant option is either true/false removing unset. Also, added code so that sentry server could validate the TSentryPrivilege object constructed from the Thrift message received client. If the validation is failed exception is raised and appropriate error is message is sent. Diffs ----- sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java c056bcc sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 15b339f sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798d Diff: https://reviews.apache.org/r/54454/diff/ Testing ------- Verfied the changes using sentry thrift client. Thanks, kalyan kumar kalvagadda
