----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ -----------------------------------------------------------
(Updated Dec. 14, 2016, 10:38 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector. Changes ------- I had to address the review comments so I had to come up with a differnt fix. UNSET option for grant is valid is only valid while revoking the privileges. Added code changes to Sentry Policy Processor to handle the same. Repository: sentry Description ------- SENTRY-1548 Setting GrantOption to UNSET upsets Sentry I have made changes assuming that grant option is either true/false removing unset. Also, added code so that sentry server could validate the TSentryPrivilege object constructed from the Thrift message received client. If the validation is failed exception is raised and appropriate error is message is sent. Diffs (updated) ----- sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632d Diff: https://reviews.apache.org/r/54454/diff/ Testing ------- Verfied the changes using sentry thrift client. Thanks, kalyan kumar kalvagadda
