> On Dec. 7, 2016, 12:56 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java, > > line 16 > > <https://reviews.apache.org/r/54454/diff/1/?file=1578184#file1578184line16> > > > > This file is auto-generated by Thrift, I don't think we should touch > > these. > > kalyan kumar kalvagadda wrote: > Sasha, > > Are you sure that all of the file is auto generated? I thought creates a > template file and let lets update it.
Here is what is says at the top: /** * Autogenerated by Thrift Compiler (0.9.3) * * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING * @generated */ Do you have any reasons to think otherwise? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review158278 ----------------------------------------------------------- On Dec. 14, 2016, 10:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54454/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 10:38 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, > and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1548 Setting GrantOption to UNSET upsets Sentry > > I have made changes assuming that grant option is either true/false removing > unset. > Also, added code so that sentry server could validate the TSentryPrivilege > object constructed from the Thrift message received client. If the validation > is failed exception is raised and appropriate error is message is sent. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 898632d > > Diff: https://reviews.apache.org/r/54454/diff/ > > > Testing > ------- > > Verfied the changes using sentry thrift client. > > > Thanks, > > kalyan kumar kalvagadda > >
