> On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 53 (patched) > > <https://reviews.apache.org/r/59869/diff/7/?file=1746528#file1746528line53> > > > > do you neeed a list or Collection is good enough?
List is needed. > On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 108 (patched) > > <https://reviews.apache.org/r/59869/diff/7/?file=1746528#file1746528line108> > > > > I think that ID collapser may be useful for other person, so it makes > > sense to have a common (not in MSentryUtil) function that collapses list of > > Long values and just call it here. Moved it to a new class SentryUtils under core-common - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177446 ----------------------------------------------------------- On June 9, 2017, 9:38 p.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 9:38 p.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 17856a4425be5c8971c51f7cfd9b2ef06001a2ab > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59869/diff/8/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
