> On June 12, 2017, 11:32 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > > Lines 40 (patched) > > <https://reviews.apache.org/r/59869/diff/9/?file=1747445#file1747445line40> > > > > Would it make sense to take care of the empty input array inline? > > Vamsee Yarlagadda wrote: > Shouldn't make a big difference between passing an array vs list right? > Just that having array will just make the function more generic. But as long > as we control the function definition, it should be ok. > > Alexander Kolbasov wrote: > What I meant was whether it makes sense to check for the isEmpty() case > upfront or not.
Oh that shouldn't be a worry at all. The logic takes care of empty lists as well. Added a test for this too. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177680 ----------------------------------------------------------- On June 14, 2017, 12:31 a.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 14, 2017, 12:31 a.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > PRE-CREATION > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestSentryUtils.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 17856a4425be5c8971c51f7cfd9b2ef06001a2ab > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59869/diff/10/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
